Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: src/typing-asm.h

Issue 1642993002: Accurately type foreign functions, and variables. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/typing-asm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing-asm.h
diff --git a/src/typing-asm.h b/src/typing-asm.h
index b7f53831e6222d96d6552351d55fa7bd7e235db7..63e204e50a7cdac4cdcc128098b622845ea01754 100644
--- a/src/typing-asm.h
+++ b/src/typing-asm.h
@@ -113,6 +113,7 @@ class AsmTyper : public AstVisitor {
bool in_function_; // In module function?
bool building_function_tables_;
+ bool visiting_exports_;
TypeCache const& cache_;
@@ -161,6 +162,8 @@ class AsmTyper : public AstVisitor {
void VisitLiteral(Literal* expr, bool is_return);
+ void VisitVariableProxy(VariableProxy* expr, bool assignment);
aseemgarg 2016/01/28 23:09:59 make this private?
bradn 2016/01/29 01:03:38 It is?
+
void VisitIntegerBitwiseOperator(BinaryOperation* expr, Type* left_expected,
Type* right_expected, Type* result_type,
bool conversion);
« no previous file with comments | « no previous file | src/typing-asm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698