Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1642493002: Add type info to JSArray. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: array changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index e07e2b8a92aa8440437de1bbac98d5bb8381669a..db1592db3216b5064fdcdb6cb4ef381eeb0ca0f7 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -295,8 +295,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitCreateInstance(cps_ir.CreateInstance node) {
String className = node.classElement.name;
String arguments = node.arguments.map(formatReference).join(', ');
- String typeInformation =
- node.typeInformation.map(formatReference).join(', ');
+ String typeInformation = formatReference(node.typeInformation);
return 'CreateInstance $className ($arguments) <$typeInformation>';
}
@@ -320,7 +319,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
}
visitTypeExpression(cps_ir.TypeExpression node) {
- return "TypeExpression ${node.dartType} "
+ return "TypeExpression ${node.kindAsString} ${node.dartType}"
"${node.arguments.map(formatReference).join(', ')}";
}

Powered by Google App Engine
This is Rietveld 408576698