Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1642493002: Add type info to JSArray. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: array changes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
index daa8408d436896f2bf3458651fd409aa7b1ce701..37836bf77175f1470426782a107b5df8df90a894 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
@@ -361,7 +361,7 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
String visitCreateInstance(CreateInstance node) {
String className = node.classElement.name;
String arguments = node.arguments.map(access).join(' ');
- String typeInformation = node.typeInformation.map(access).join(' ');
+ String typeInformation = optionalAccess(node.typeInformation);
return '(CreateInstance $className ($arguments) ($typeInformation))';
}
@@ -379,7 +379,7 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
String visitTypeExpression(TypeExpression node) {
String args = node.arguments.map(access).join(' ');
- return '(TypeExpression ${node.dartType} ($args))';
+ return '(TypeExpression ${node.kindAsString} ${node.dartType} ($args))';
}
String visitCreateInvocationMirror(CreateInvocationMirror node) {

Powered by Google App Engine
This is Rietveld 408576698