Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 1642453002: [mojo-edk] Fix shutdown with old EDK. (Closed)

Created:
4 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 11 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Fix shutdown with old EDK. The old EDK always initializes the new EDK as well, but it wasn't shutting it down unless --use-new-edk was set. This was hitting CHECKs to guard against double-initialization, because tests init and shutdown the EDK multiple times in the same process. This CL fixes that by always shutting the new EDK down as well. Also we don't actually use g_io_thread_task_runner anymore so I removed that. TBRing since it's a pretty obvious fix IMHO and it's breaking stuff on bots. BUG=None TBR=jam@chromium.org Committed: https://crrev.com/3d0e9ea31ad19497d1328354ab75be25b9f9ad6a Cr-Commit-Position: refs/heads/master@{#371748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -29 lines) Patch
M mojo/edk/embedder/embedder.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/edk/embedder/embedder_internal.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.cc View 1 chunk +20 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ken Rockot(use gerrit already)
4 years, 11 months ago (2016-01-27 05:23:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642453002/1
4 years, 11 months ago (2016-01-27 05:23:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 06:23:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 06:25:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d0e9ea31ad19497d1328354ab75be25b9f9ad6a
Cr-Commit-Position: refs/heads/master@{#371748}

Powered by Google App Engine
This is Rietveld 408576698