Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/mojo/src/mojo/edk/embedder/embedder.cc

Issue 1642453002: [mojo-edk] Fix shutdown with old EDK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/embedder/embedder_internal.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/mojo/src/mojo/edk/embedder/embedder.cc
diff --git a/third_party/mojo/src/mojo/edk/embedder/embedder.cc b/third_party/mojo/src/mojo/edk/embedder/embedder.cc
index f55291e5aea45d1d903cd6061f06c5cdeada7fd4..ada0d38b9d3ee41eda2e576abb1d6abe34e1baca 100644
--- a/third_party/mojo/src/mojo/edk/embedder/embedder.cc
+++ b/third_party/mojo/src/mojo/edk/embedder/embedder.cc
@@ -229,35 +229,32 @@ void InitIPCSupport(ProcessType process_type,
}
void ShutdownIPCSupportOnIOThread() {
- if (UseNewEDK()) {
- mojo::edk::ShutdownIPCSupportOnIOThread();
- return;
+ if (!UseNewEDK()) {
+ DCHECK(internal::g_ipc_support);
+
+ internal::g_ipc_support->ShutdownOnIOThread();
+ delete internal::g_ipc_support;
+ internal::g_ipc_support = nullptr;
+ delete g_wrapper_process_delegate;
+ g_wrapper_process_delegate = nullptr;
}
-
- DCHECK(internal::g_ipc_support);
-
- internal::g_ipc_support->ShutdownOnIOThread();
- delete internal::g_ipc_support;
- internal::g_ipc_support = nullptr;
- delete g_wrapper_process_delegate;
- g_wrapper_process_delegate = nullptr;
+ mojo::edk::ShutdownIPCSupportOnIOThread();
}
void ShutdownIPCSupport() {
- if (UseNewEDK()) {
+ if (!UseNewEDK()) {
+ DCHECK(internal::g_ipc_support);
+
+ ProcessDelegate* delegate = internal::g_ipc_support->process_delegate();
+ bool ok = internal::g_ipc_support->io_thread_task_runner()->PostTaskAndReply(
+ FROM_HERE,
+ base::Bind(&ShutdownIPCSupportOnIOThread),
+ base::Bind(&ProcessDelegate::OnShutdownComplete,
+ base::Unretained(delegate)));
+ DCHECK(ok);
+ } else {
mojo::edk::ShutdownIPCSupport();
- return;
}
-
- DCHECK(internal::g_ipc_support);
-
- ProcessDelegate* delegate = internal::g_ipc_support->process_delegate();
- bool ok = internal::g_ipc_support->io_thread_task_runner()->PostTaskAndReply(
- FROM_HERE,
- base::Bind(&ShutdownIPCSupportOnIOThread),
- base::Bind(&ProcessDelegate::OnShutdownComplete,
- base::Unretained(delegate)));
- DCHECK(ok);
}
ScopedMessagePipeHandle ConnectToSlave(
« no previous file with comments | « mojo/edk/embedder/embedder_internal.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698