Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1642303002: Add the VMLS instruction to the integrated ARM assembler. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add DART files. #

Total comments: 2

Patch Set 3 : Fix comment in test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -27 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +24 lines, -3 lines 0 comments Download
A + tests_lit/assembler/arm32/vmls.ll View 1 2 2 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Karl
4 years, 10 months ago (2016-01-28 23:38:04 UTC) #3
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-01-29 00:56:09 UTC) #4
John
lgtm https://codereview.chromium.org/1642303002/diff/20001/tests_lit/assembler/arm32/vmls.ll File tests_lit/assembler/arm32/vmls.ll (right): https://codereview.chromium.org/1642303002/diff/20001/tests_lit/assembler/arm32/vmls.ll#newcode5 tests_lit/assembler/arm32/vmls.ll:5: ; available for the fsub. When using -Om1, ...
4 years, 10 months ago (2016-01-29 01:35:34 UTC) #5
Karl
Committed patchset #3 (id:40001) manually as 694cdbd8020f97334c24ad5cd39cf1d8b0b2868b (presubmit successful).
4 years, 10 months ago (2016-01-29 15:23:25 UTC) #8
Karl
4 years, 10 months ago (2016-01-29 15:23:35 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1642303002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vmls.ll (right):

https://codereview.chromium.org/1642303002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vmls.ll:5: ; available for the fsub. When using -Om1,
the merge of fmul and fsub does not
On 2016/01/29 01:35:34, John wrote:
> Not true -- the merge does not happen because Om1 -- and lack of liveness
> information.

Corrected sentence.

Powered by Google App Engine
This is Rietveld 408576698