Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: extensions/renderer/dispatcher.h

Issue 1642283002: Deal with frame removal by content scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Push down WeakPtr Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/dispatcher.h
diff --git a/extensions/renderer/dispatcher.h b/extensions/renderer/dispatcher.h
index 40194a06d2ab6a40e83b300a226098bcbfb8aa26..b6880066d3a3aad3f484548e083086de0a4d14f1 100644
--- a/extensions/renderer/dispatcher.h
+++ b/extensions/renderer/dispatcher.h
@@ -108,7 +108,11 @@ class Dispatcher : public content::RenderProcessObserver,
v8::Local<v8::Context> v8_context,
const GURL& url);
+ // This method is not allowed to run JavaScript code in the frame.
Devlin 2016/02/12 22:21:56 Can we DCHECK this (in general for DidCreateDocume
robwu 2016/02/12 22:37:13 Blink has ScriptForbiddenScope, but it's not publi
Devlin 2016/02/12 22:51:01 SG. Can we put an artfully placed TODO somewhere?
robwu 2016/02/12 23:24:49 I'll add a comment at the next update to the macro
void DidCreateDocumentElement(blink::WebLocalFrame* frame);
+ // This method may run (untrusted) JavaScript code in the frame.
+ void AfterDidCreateDocumentElement(content::RenderFrame* render_frame);
+ void AfterDidFinishDocumentLoad(content::RenderFrame* render_frame);
void OnExtensionResponse(int request_id,
bool success,

Powered by Google App Engine
This is Rietveld 408576698