Deal with frame removal by content scripts

extensions/renderer/dispatcher.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_DISPATCHER_H_
 #define EXTENSIONS_RENDERER_DISPATCHER_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 90 matching lines @@
 
   void WillReleaseScriptContext(blink::WebLocalFrame* frame,
                                 const v8::Local<v8::Context>& context,
                                 int world_id);
 
   // Runs on a different thread and should not use any member variables.
   static void WillDestroyServiceWorkerContextOnWorkerThread(
       v8::Local<v8::Context> v8_context,
       const GURL& url);
 
+  // This method is not allowed to run JavaScript code in the frame.

[Devlin, 2016/02/12 22:21:56]

Can we DCHECK this (in general for DidCreateDocumentElement) somewhere in the
blink layer? Are we already?

[robwu, 2016/02/12 22:37:13]

Blink has ScriptForbiddenScope, but it's not public.
I am reluctant to add this restriction now, because of the risk of breaking
functionality in a merge. See https://codereview.chromium.org/1642283002/#msg34

[Devlin, 2016/02/12 22:51:01]

SG.  Can we put an artfully placed TODO somewhere?

[robwu, 2016/02/12 23:24:49]

I'll add a comment at the next update to the macros at content/.

   void DidCreateDocumentElement(blink::WebLocalFrame* frame);
+  // This method may run (untrusted) JavaScript code in the frame.
+  void AfterDidCreateDocumentElement(content::RenderFrame* render_frame);
+  void AfterDidFinishDocumentLoad(content::RenderFrame* render_frame);
 
   void OnExtensionResponse(int request_id,
                            bool success,
                            const base::ListValue& response,
                            const std::string& error);
 
   // Dispatches the event named |event_name| to all render views.
   void DispatchEvent(const std::string& extension_id,
                      const std::string& event_name) const;
 
@@ skipping 185 matching lines @@
   // if this renderer is a WebView guest render process. Otherwise, this will be
   // empty.
   std::string webview_partition_id_;
 
   DISALLOW_COPY_AND_ASSIGN(Dispatcher);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_DISPATCHER_H_