Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1642093002: Purge the ScrollBlocksOn code. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge the ScrollBlocksOn code. The ScrollBlocksOn code needs to be removed since passive event listeners is the approach going forward. BUG=489802 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d Cr-Commit-Position: refs/heads/master@{#372129}

Patch Set 1 #

Patch Set 2 : Fix android build failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -391 lines) Patch
M cc/blink/web_layer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M cc/layers/layer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M cc/layers/layer.cc View 5 chunks +0 lines, -12 lines 0 comments Download
M cc/layers/layer_impl.h View 3 chunks +1 line, -11 lines 0 comments Download
M cc/layers/layer_impl.cc View 6 chunks +2 lines, -30 lines 0 comments Download
M cc/layers/layer_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
D cc/layers/scroll_blocks_on.h View 1 chunk +0 lines, -26 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/proto/layer.proto View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_json_parser.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +5 lines, -26 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 3 chunks +4 lines, -179 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M cc/trees/property_tree.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 3 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 2 chunks +0 lines, -5 lines 0 comments Download
D third_party/WebKit/public/platform/WebScrollBlocksOn.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dtapuska
4 years, 10 months ago (2016-01-28 14:26:25 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 10 months ago (2016-01-28 17:43:22 UTC) #5
Rick Byers
LGTM - thanks
4 years, 10 months ago (2016-01-28 18:41:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642093002/20001
4 years, 10 months ago (2016-01-28 18:43:32 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 19:18:21 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 19:19:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd423123b7c269a40334624e10ec4b10c2d0682d
Cr-Commit-Position: refs/heads/master@{#372129}

Powered by Google App Engine
This is Rietveld 408576698