DevTools: remove V8ScriptRunner use from InjectedScript*.

DevTools: remove V8ScriptRunner use from InjectedScript*.

BUG=580337
Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
Cr-Commit-Position: refs/heads/master@{#372020}

[pfeldman, 2016-01-27 23:23:48]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org, jochen@chromium.org

[dgozman, 2016-01-28 00:21:48]

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp (right):

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp:20: static
const char privateKeyName[] = "v8-inspector#injectedScript";
Either name it more specificly or put into anonymous namespace.

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp:29:
injectedScriptHost->SetPrivate(m_isolate->GetCurrentContext(), privateKey,
external);
Let's pass context explicitly?

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h (right):

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h:24: virtual
v8::MaybeLocal<v8::Value> compileAndRunInternalScript(const String& script) = 0;
I think we'd better pass context instead of assuming it's current.

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h:26: virtual
v8::MaybeLocal<v8::Value> callInternalFunction(v8::Local<v8::Function>,
v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) = 0;
ditto

[pfeldman, 2016-01-28 00:29:42]

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp (right):

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp:20: static
const char privateKeyName[] = "v8-inspector#injectedScript";
On 2016/01/28 00:21:48, dgozman wrote:
> Either name it more specificly or put into anonymous namespace.

Why?

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp:29:
injectedScriptHost->SetPrivate(m_isolate->GetCurrentContext(), privateKey,
external);
On 2016/01/28 00:21:48, dgozman wrote:
> Let's pass context explicitly?

Did not do that on purpose - the fetch goes over the current path.

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h (right):

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h:24: virtual
v8::MaybeLocal<v8::Value> compileAndRunInternalScript(const String& script) = 0;
On 2016/01/28 00:21:48, dgozman wrote:
> I think we'd better pass context instead of assuming it's current.

I mimick the V8Runner API here. But I hear you, will do in a follow-up.

https://codereview.chromium.org/1641933002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h:26: virtual
v8::MaybeLocal<v8::Value> callInternalFunction(v8::Local<v8::Function>,
v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) = 0;
On 2016/01/28 00:21:48, dgozman wrote:
> ditto

ditto

[pfeldman, 2016-01-28 00:35:37]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-01-28 00:36:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641933002/20001

[commit-bot: I haz the power, 2016-01-28 00:36:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 00:36:53]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[haraken, 2016-01-28 00:39:17]

On 2016/01/28 00:36:53, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

bindings LGTM

[dgozman, 2016-01-28 01:05:06]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-01-28 01:05:07]

lgtm

[commit-bot: I haz the power, 2016-01-28 01:06:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641933002/20001

[commit-bot: I haz the power, 2016-01-28 01:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 01:10:54]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-01-28 01:27:15]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-01-28 01:29:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641933002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641933002/20001

[commit-bot: I haz the power, 2016-01-28 05:21:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 05:22:42]

Description was changed from

==========
DevTools: remove V8ScriptRunner use from InjectedScript*.

BUG=580337
==========

to

==========
DevTools: remove V8ScriptRunner use from InjectedScript*.

BUG=580337

Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
Cr-Commit-Position: refs/heads/master@{#372020}
==========

[commit-bot: I haz the power, 2016-01-28 05:22:43]

Patchset 2 (id:??) landed as
https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
Cr-Commit-Position: refs/heads/master@{#372020}

[Noel Gordon, 2016-01-28 06:36:16]

http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get it to pass again.

[Noel Gordon, 2016-01-28 06:37:05]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1646803002/ by noel@chromium.org.

The reason for reverting is:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again..