Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h

Issue 1641933002: DevTools: remove V8ScriptRunner use from InjectedScript*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h
index 5d79c949eb44965be90441656b1e1c4ad0125667..9b5ad436c700552d887a7e0da86ced17533b48c7 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h
+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h
@@ -16,12 +16,15 @@ class CORE_EXPORT V8DebuggerClient {
USING_FAST_MALLOC(V8DebuggerClient);
public:
virtual ~V8DebuggerClient() { }
- virtual v8::Local<v8::Object> compileDebuggerScript() = 0;
virtual void runMessageLoopOnPause(int contextGroupId) = 0;
virtual void quitMessageLoopOnPause() = 0;
virtual void eventListeners(v8::Local<v8::Value>, EventListenerInfoMap&) = 0;
virtual bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) = 0;
+
+ virtual v8::MaybeLocal<v8::Value> compileAndRunInternalScript(const String& script) = 0;
dgozman 2016/01/28 00:21:48 I think we'd better pass context instead of assumi
pfeldman 2016/01/28 00:29:42 I mimick the V8Runner API here. But I hear you, wi
virtual v8::MaybeLocal<v8::Value> callFunction(v8::Local<v8::Function>, v8::Local<v8::Context>, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) = 0;
+ virtual v8::MaybeLocal<v8::Value> callInternalFunction(v8::Local<v8::Function>, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) = 0;
dgozman 2016/01/28 00:21:48 ditto
pfeldman 2016/01/28 00:29:42 ditto
+
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698