Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 164183002: A64: Implement division in Lithium for smis (Closed)

Created:
6 years, 10 months ago by m.m.capewell
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Implement division in Lithium for smis Implemented by splitting division into constant and non-constant RHS instructions, and updating each for smi inputs. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -120 lines) Patch
M src/a64/lithium-a64.h View 2 chunks +25 lines, -4 lines 0 comments Download
M src/a64/lithium-a64.cc View 1 chunk +16 lines, -10 lines 0 comments Download
M src/a64/lithium-codegen-a64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 2 chunks +146 lines, -106 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
m.m.capewell
6 years, 10 months ago (2014-02-13 17:56:59 UTC) #1
jochen (gone - plz use gerrit)
I defer to Ulan
6 years, 10 months ago (2014-02-17 14:34:39 UTC) #2
Sven Panne
Please delay this CL until I have landed https://codereview.chromium.org/166793002/, which includes a real bug fix.
6 years, 10 months ago (2014-02-18 07:11:30 UTC) #3
Sven Panne
As just discussed with Ulan offline, the master plan for this is as follows: I'll ...
6 years, 10 months ago (2014-02-18 09:16:28 UTC) #4
Sven Panne
After having a closer look at the code and some discussions with Benedikt, we decided ...
6 years, 10 months ago (2014-02-18 10:44:44 UTC) #5
m.m.capewell
6 years, 10 months ago (2014-02-19 14:36:20 UTC) #6
OK, this sounds good. I'll close this review.

Powered by Google App Engine
This is Rietveld 408576698