Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: runtime/vm/debugger.h

Issue 1641793002: Fix a bug where breakpoints where not getting properly deleted. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: reorder line Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.h
diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h
index acb69ec747c3b2dc2072674e173d94de14d6de5c..5696e963a39b72aa3cca33a11317d2a6e287ce30 100644
--- a/runtime/vm/debugger.h
+++ b/runtime/vm/debugger.h
@@ -651,7 +651,8 @@ class Debugger {
// interrupts, etc.
void Pause(DebuggerEvent* event);
- void HandleSteppingRequest(DebuggerStackTrace* stack_trace);
+ void HandleSteppingRequest(DebuggerStackTrace* stack_trace,
+ bool skip_next_step = false);
Isolate* isolate_;
Dart_Port isolate_id_; // A unique ID for the isolate in the debugger.
@@ -690,6 +691,11 @@ class Debugger {
// lower on the stack.
uword stepping_fp_;
+ // If we step while at a breakpoint, we would hit the same pc twice.
+ // We use this field to let us skip the next single-step after a
+ // breakpoint.
+ bool skip_next_step_;
+
Dart_ExceptionPauseInfo exc_pause_info_;
static EventHandler* event_handler_;
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698