Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: runtime/vm/debugger.h

Issue 1641793002: Fix a bug where breakpoints where not getting properly deleted. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: reorder line Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_DEBUGGER_H_ 5 #ifndef VM_DEBUGGER_H_
6 #define VM_DEBUGGER_H_ 6 #define VM_DEBUGGER_H_
7 7
8 #include "include/dart_tools_api.h" 8 #include "include/dart_tools_api.h"
9 9
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 644
645 void CollectLibraryFields(const GrowableObjectArray& field_list, 645 void CollectLibraryFields(const GrowableObjectArray& field_list,
646 const Library& lib, 646 const Library& lib,
647 const String& prefix, 647 const String& prefix,
648 bool include_private_fields); 648 bool include_private_fields);
649 649
650 // Handles any events which pause vm execution. Breakpoints, 650 // Handles any events which pause vm execution. Breakpoints,
651 // interrupts, etc. 651 // interrupts, etc.
652 void Pause(DebuggerEvent* event); 652 void Pause(DebuggerEvent* event);
653 653
654 void HandleSteppingRequest(DebuggerStackTrace* stack_trace); 654 void HandleSteppingRequest(DebuggerStackTrace* stack_trace,
655 bool skip_next_step = false);
655 656
656 Isolate* isolate_; 657 Isolate* isolate_;
657 Dart_Port isolate_id_; // A unique ID for the isolate in the debugger. 658 Dart_Port isolate_id_; // A unique ID for the isolate in the debugger.
658 bool initialized_; 659 bool initialized_;
659 bool creation_message_sent_; // The creation message has been sent. 660 bool creation_message_sent_; // The creation message has been sent.
660 661
661 // ID number generator. 662 // ID number generator.
662 intptr_t next_id_; 663 intptr_t next_id_;
663 664
664 BreakpointLocation* latent_locations_; 665 BreakpointLocation* latent_locations_;
(...skipping 18 matching lines...) Expand all
683 RemoteObjectCache* obj_cache_; 684 RemoteObjectCache* obj_cache_;
684 685
685 // Current stack trace. Valid only while IsPaused(). 686 // Current stack trace. Valid only while IsPaused().
686 DebuggerStackTrace* stack_trace_; 687 DebuggerStackTrace* stack_trace_;
687 688
688 // When stepping through code, only pause the program if the top 689 // When stepping through code, only pause the program if the top
689 // frame corresponds to this fp value, or if the top frame is 690 // frame corresponds to this fp value, or if the top frame is
690 // lower on the stack. 691 // lower on the stack.
691 uword stepping_fp_; 692 uword stepping_fp_;
692 693
694 // If we step while at a breakpoint, we would hit the same pc twice.
695 // We use this field to let us skip the next single-step after a
696 // breakpoint.
697 bool skip_next_step_;
698
693 Dart_ExceptionPauseInfo exc_pause_info_; 699 Dart_ExceptionPauseInfo exc_pause_info_;
694 700
695 static EventHandler* event_handler_; 701 static EventHandler* event_handler_;
696 702
697 friend class Isolate; 703 friend class Isolate;
698 friend class BreakpointLocation; 704 friend class BreakpointLocation;
699 DISALLOW_COPY_AND_ASSIGN(Debugger); 705 DISALLOW_COPY_AND_ASSIGN(Debugger);
700 }; 706 };
701 707
702 708
703 } // namespace dart 709 } // namespace dart
704 710
705 #endif // VM_DEBUGGER_H_ 711 #endif // VM_DEBUGGER_H_
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/test_helper.dart ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698