rewrite_to_chrome_style: skip nodes expanded from macros

rewrite_to_chrome_style: skip nodes expanded from macros

Since the tool wasn't using the "spelling" location, replacements would
be emitted using source locations into an unnamed input buffer. As a
result, the emitted replacements would never apply since the file name
would never match.

However, it ends up still being included in the symbol dump for the
rebase tool. Since these identifiers aren't being renamed, just skip
processing anything inside a macro.

BUG=581902
Committed: https://crrev.com/7370c5666dc5fb4f29af86c6daa18657599bf2ed
Cr-Commit-Position: refs/heads/master@{#372203}

[dcheng, 2016-01-28 06:46:46]

Description was changed from

==========
moo
=--------------------This line is 72 characters long--------------------

BUG=581902
==========

to

==========
rewrite_to_chrome_style: skip nodes expanded from macros

Since the tool wasn't using the "spelling" location, replacements would
be emitted using source locations into an unnamed input buffer. As a
result, the emitted replacements would never apply since the file name
would never match.

However, it ends up still being included in the symbol dump for the
rebase tool. Since these identifiers aren't being renamed, just skip
processing anything inside a macro.

BUG=581902
==========

[dcheng, 2016-01-28 06:46:46]

dcheng@chromium.org changed reviewers:
+ danakj@chromium.org

[dcheng, 2016-01-28 06:47:43]

Note: I'm a little fuzzy on how clang's macro expansion all works internally, so
there's some conjecture on the theory of why it wasn't getting processed before.
But the new version is definitely correct, as far as I can tell, with no
handwavy explanations required.

https://codereview.chromium.org/1641703003/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1641703003/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:231: if (old_name
== new_name)
I moved this up to reduce the amount of edits emitted by the tool.

[danakj, 2016-01-28 23:03:13]

LGTM

[danakj, 2016-01-28 23:03:17]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-28 23:04:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641703003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641703003/1

[commit-bot: I haz the power, 2016-01-28 23:26:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-28 23:27:49]

Description was changed from

==========
rewrite_to_chrome_style: skip nodes expanded from macros

Since the tool wasn't using the "spelling" location, replacements would
be emitted using source locations into an unnamed input buffer. As a
result, the emitted replacements would never apply since the file name
would never match.

However, it ends up still being included in the symbol dump for the
rebase tool. Since these identifiers aren't being renamed, just skip
processing anything inside a macro.

BUG=581902
==========

to

==========
rewrite_to_chrome_style: skip nodes expanded from macros

Since the tool wasn't using the "spelling" location, replacements would
be emitted using source locations into an unnamed input buffer. As a
result, the emitted replacements would never apply since the file name
would never match.

However, it ends up still being included in the symbol dump for the
rebase tool. Since these identifiers aren't being renamed, just skip
processing anything inside a macro.

BUG=581902

Committed: https://crrev.com/7370c5666dc5fb4f29af86c6daa18657599bf2ed
Cr-Commit-Position: refs/heads/master@{#372203}
==========

[commit-bot: I haz the power, 2016-01-28 23:27:50]

Patchset 1 (id:??) landed as
https://crrev.com/7370c5666dc5fb4f29af86c6daa18657599bf2ed
Cr-Commit-Position: refs/heads/master@{#372203}