rewrite_to_chrome_style: skip nodes expanded from macros

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Changes Blink-style names to Chrome-style names. Currently transforms:
 //   fields:
 //     int m_operationCount => int operation_count_
 //   variables (including parameters):
 //     int mySuperVariable => int my_super_variable
 //   constants:
@@ skipping 204 matching lines @@
 };
 constexpr char TargetNodeTraits<clang::CXXCtorInitializer>::kName[];
 
 template <typename DeclNode, typename TargetNode>
 class RewriterBase : public MatchFinder::MatchCallback {
  public:
   explicit RewriterBase(Replacements* replacements)
       : replacements_(replacements) {}
 
   void run(const MatchFinder::MatchResult& result) override {
-    std::string name;
+    std::string new_name;
     const DeclNode* decl = result.Nodes.getNodeAs<DeclNode>("decl");
     clang::ASTContext* context = result.Context;
-    if (!GetNameForDecl(*decl, *context, name))
+    if (!GetNameForDecl(*decl, *context, new_name))
       return;
-    auto r = replacements_->emplace(
-        *result.SourceManager, TargetNodeTraits<TargetNode>::GetRange(
-                                   *result.Nodes.getNodeAs<TargetNode>(
-                                       TargetNodeTraits<TargetNode>::kName)),
-        name);
-    auto from = decl->getNameAsString();
-    auto to = r.first->getReplacementText().str();
-    if (from != to)
-      replacement_names_.emplace(std::move(from), std::move(to));
+    llvm::StringRef old_name = decl->getName();
+    if (old_name == new_name)

[dcheng, 2016/01/28 06:47:42]

I moved this up to reduce the amount of edits emitted by the tool.

+      return;
+    clang::CharSourceRange range = TargetNodeTraits<TargetNode>::GetRange(
+        *result.Nodes.getNodeAs<TargetNode>(
+            TargetNodeTraits<TargetNode>::kName));
+    if (range.getBegin().isMacroID() || range.getEnd().isMacroID())
+      return;
+    replacements_->emplace(*result.SourceManager, range, new_name);
+    replacement_names_.emplace(old_name.str(), std::move(new_name));
   }
 
   const std::unordered_map<std::string, std::string>& replacement_names()
       const {
     return replacement_names_;
   }
 
  private:
   Replacements* const replacements_;
   std::unordered_map<std::string, std::string> replacement_names_;
@@ skipping 306 matching lines @@
   for (const auto& r : replacements) {
     std::string replacement_text = r.getReplacementText().str();
     std::replace(replacement_text.begin(), replacement_text.end(), '\n', '\0');
     llvm::outs() << "r:::" << r.getFilePath() << ":::" << r.getOffset()
                  << ":::" << r.getLength() << ":::" << replacement_text << "\n";
   }
   llvm::outs() << "==== END EDITS ====\n";
 
   return 0;
 }