Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 1641703002: support symlinks in zip files in build_utils.ExtractAll (Closed)

Created:
4 years, 11 months ago by Mostyn Bramley-Moore
Modified:
4 years, 10 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

support symlinks in zip files in build_utils.ExtractAll Without this, extracting zip files which contain symlinks does not work- instead of creating symlinks, regular files are written with the symlink target. Committed: https://crrev.com/b5b49118799533bb4066d98d97990d3a7d60e7aa Cr-Commit-Position: refs/heads/master@{#372557}

Patch Set 1 #

Total comments: 1

Patch Set 2 : use the MakeDirectory function #

Total comments: 2

Patch Set 3 : figured out what ZipInfo.external_attr is actually #

Total comments: 2

Patch Set 4 : just return S_ISLNK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M build/android/gyp/util/build_utils.py View 1 2 3 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 25 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641703002/1
4 years, 11 months ago (2016-01-27 17:06:49 UTC) #2
Mostyn Bramley-Moore
@rnephew1: please take a look at this small change, which adds support for symlinks in ...
4 years, 11 months ago (2016-01-27 17:11:08 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-27 18:20:07 UTC) #7
rnephew (Reviews Here)
lgtm, but please wait for John to look at this, he is more familiar with ...
4 years, 10 months ago (2016-01-28 20:31:06 UTC) #9
Mostyn Bramley-Moore
https://codereview.chromium.org/1641703002/diff/1/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/1/build/android/gyp/util/build_utils.py#newcode236 build/android/gyp/util/build_utils.py:236: os.makedirs(dest_dir) I should use the MakeDirectory function here, I ...
4 years, 10 months ago (2016-01-28 21:20:41 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641703002/20001
4 years, 10 months ago (2016-01-28 21:22:43 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-28 22:45:03 UTC) #14
jbudorick
https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/build_utils.py#newcode204 build/android/gyp/util/build_utils.py:204: if zi.external_attr & symlink_attr == symlink_attr: does stat.S_ISLNK(zi.external_attr) work ...
4 years, 10 months ago (2016-01-30 01:52:56 UTC) #15
Mostyn Bramley-Moore
https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/build_utils.py#newcode204 build/android/gyp/util/build_utils.py:204: if zi.external_attr & symlink_attr == symlink_attr: On 2016/01/30 01:52:56, ...
4 years, 10 months ago (2016-01-30 12:57:05 UTC) #16
jbudorick
lgtm w/ nit https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/build_utils.py#newcode207 build/android/gyp/util/build_utils.py:207: if stat.S_ISLNK(zi.external_attr >> 16L): nit: just ...
4 years, 10 months ago (2016-01-30 17:33:37 UTC) #17
Mostyn Bramley-Moore
https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/build_utils.py File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/build_utils.py#newcode207 build/android/gyp/util/build_utils.py:207: if stat.S_ISLNK(zi.external_attr >> 16L): On 2016/01/30 17:33:37, jbudorick wrote: ...
4 years, 10 months ago (2016-01-30 17:41:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641703002/60001
4 years, 10 months ago (2016-01-30 17:41:37 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-01-30 19:03:28 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 19:04:34 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b5b49118799533bb4066d98d97990d3a7d60e7aa
Cr-Commit-Position: refs/heads/master@{#372557}

Powered by Google App Engine
This is Rietveld 408576698