Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1641703002:
support symlinks in zip files in build_utils.ExtractAll (Closed)
|
Created:
4 years, 11 months ago by Mostyn Bramley-Moore Modified:
4 years, 10 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionsupport symlinks in zip files in build_utils.ExtractAll
Without this, extracting zip files which contain symlinks does not
work- instead of creating symlinks, regular files are written with
the symlink target.
Committed: https://crrev.com/b5b49118799533bb4066d98d97990d3a7d60e7aa
Cr-Commit-Position: refs/heads/master@{#372557}
Patch Set 1 #
Total comments: 1
Patch Set 2 : use the MakeDirectory function #
Total comments: 2
Patch Set 3 : figured out what ZipInfo.external_attr is actually #
Total comments: 2
Patch Set 4 : just return S_ISLNK #Messages
Total messages: 25 (11 generated)
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641703002/1
Description was changed from ========== support extracting symlinks from zip files in build_utils.py Without this, extracting zip files which contain symlinks does not work- instead of creating symlinks, regular files are written with the symlink target. ========== to ========== support symlinks in zip files in build_utils.ExtractAll Without this, extracting zip files which contain symlinks does not work- instead of creating symlinks, regular files are written with the symlink target. ==========
mostynb@opera.com changed reviewers: + rnephew@chromium.org
@rnephew1: please take a look at this small change, which adds support for symlinks in zip files when using build_utils.ExtractAll.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rnephew@chromium.org changed reviewers: + jbudorick@chromium.org
lgtm, but please wait for John to look at this, he is more familiar with the build systems.
https://codereview.chromium.org/1641703002/diff/1/build/android/gyp/util/buil... File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/1/build/android/gyp/util/buil... build/android/gyp/util/build_utils.py:236: os.makedirs(dest_dir) I should use the MakeDirectory function here, I guess.
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641703002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641703002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/... File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/... build/android/gyp/util/build_utils.py:204: if zi.external_attr & symlink_attr == symlink_attr: does stat.S_ISLNK(zi.external_attr) work here?
https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/... File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/20001/build/android/gyp/util/... build/android/gyp/util/build_utils.py:204: if zi.external_attr & symlink_attr == symlink_attr: On 2016/01/30 01:52:56, jbudorick wrote: > does stat.S_ISLNK(zi.external_attr) work here? It works if you pass only the two high order bytes of external_attr (done in patchset 3).
lgtm w/ nit https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/... File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/... build/android/gyp/util/build_utils.py:207: if stat.S_ISLNK(zi.external_attr >> 16L): nit: just return stat.S_ISLNK(zi.external_attr >> 16L)
https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/... File build/android/gyp/util/build_utils.py (right): https://codereview.chromium.org/1641703002/diff/40001/build/android/gyp/util/... build/android/gyp/util/build_utils.py:207: if stat.S_ISLNK(zi.external_attr >> 16L): On 2016/01/30 17:33:37, jbudorick wrote: > nit: just > > return stat.S_ISLNK(zi.external_attr >> 16L) Done.
The CQ bit was checked by mostynb@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from rnephew@chromium.org, jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/1641703002/#ps60001 (title: "just return S_ISLNK")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641703002/60001
Message was sent while issue was closed.
Description was changed from ========== support symlinks in zip files in build_utils.ExtractAll Without this, extracting zip files which contain symlinks does not work- instead of creating symlinks, regular files are written with the symlink target. ========== to ========== support symlinks in zip files in build_utils.ExtractAll Without this, extracting zip files which contain symlinks does not work- instead of creating symlinks, regular files are written with the symlink target. ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== support symlinks in zip files in build_utils.ExtractAll Without this, extracting zip files which contain symlinks does not work- instead of creating symlinks, regular files are written with the symlink target. ========== to ========== support symlinks in zip files in build_utils.ExtractAll Without this, extracting zip files which contain symlinks does not work- instead of creating symlinks, regular files are written with the symlink target. Committed: https://crrev.com/b5b49118799533bb4066d98d97990d3a7d60e7aa Cr-Commit-Position: refs/heads/master@{#372557} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/b5b49118799533bb4066d98d97990d3a7d60e7aa Cr-Commit-Position: refs/heads/master@{#372557} |
