support symlinks in zip files in build_utils.ExtractAll

build/android/gyp/util/build_utils.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import ast
 import contextlib
 import fnmatch
 import json
 import os
 import pipes
@@ skipping 180 matching lines @@
   return device_state.strip() == 'device'
 
 
 def CheckZipPath(name):
   if os.path.normpath(name) != name:
     raise Exception('Non-canonical zip path: %s' % name)
   if os.path.isabs(name):
     raise Exception('Absolute zip path: %s' % name)
 
 
+def IsSymlink(zip_file, name):
+  zi = zip_file.getinfo(name)
+  symlink_attr = 0120000 << 16L
+  if zi.external_attr & symlink_attr == symlink_attr:

[jbudorick, 2016/01/30 01:52:56]

does stat.S_ISLNK(zi.external_attr) work here?

[Mostyn Bramley-Moore, 2016/01/30 12:57:05]

It works if you pass only the two high order bytes of external_attr (done in
patchset 3).

+    return True
+  return False
+
+
 def ExtractAll(zip_path, path=None, no_clobber=True, pattern=None,
                predicate=None):
   if path is None:
     path = os.getcwd()
   elif not os.path.exists(path):
     MakeDirectory(path)
 
   with zipfile.ZipFile(zip_path) as z:
     for name in z.namelist():
       if name.endswith('/'):
         continue
       if pattern is not None:
         if not fnmatch.fnmatch(name, pattern):
           continue
       if predicate and not predicate(name):
         continue
       CheckZipPath(name)
       if no_clobber:
         output_path = os.path.join(path, name)
         if os.path.exists(output_path):
           raise Exception(
               'Path already exists from zip: %s %s %s'
               % (zip_path, name, output_path))
-      z.extract(name, path)
+      if IsSymlink(z, name):
+        dest = os.path.join(path, name)
+        MakeDirectory(os.path.dirname(dest))
+        os.symlink(z.read(name), dest)
+      else:
+        z.extract(name, path)
 
 
 def AddToZipHermetic(zip_file, zip_path, src_path=None, data=None,
                      compress=None):
   """Adds a file to the given ZipFile with a hard-coded modified time.
 
   Args:
     zip_file: ZipFile instance to add the file to.
     zip_path: Destination path within the zip file.
     src_path: Path of the source file. Mutually exclusive with |data|.
@@ skipping 241 matching lines @@
 
   md5_check.CallAndRecordIfStale(
       on_stale_md5,
       record_path=record_path,
       input_paths=input_paths,
       input_strings=input_strings,
       output_paths=output_paths,
       force=force,
       pass_changes=True)