Stop testing SkImageDecoder in DM/nanobench

Stop testing SkImageDecoder in DM/nanobench

We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641663002

Committed: https://skia.googlesource.com/skia/+/0edf1693dfd8360f5b8256e0700c2240854c010f

[scroggo, 2016-01-27 15:16:27]

Description was changed from

==========
Stop testing SkImageDecoder in DM

We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
==========

to

==========
Stop testing SkImageDecoder in DM

We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-27 15:34:17]

Description was changed from

==========
Stop testing SkImageDecoder in DM

We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Stop testing SkImageDecoder in DM/nanobench

We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-27 15:35:09]

scroggo@google.com changed reviewers:
+ msarett@google.com

[msarett, 2016-01-27 15:52:38]

Yaaaay!!!

lgtm

https://codereview.chromium.org/1641663002/diff/60001/bench/DecodingBench.cpp
File bench/DecodingBench.cpp (left):

https://codereview.chromium.org/1641663002/diff/60001/bench/DecodingBench.cpp...
bench/DecodingBench.cpp:23: DecodingBench::DecodingBench(SkString path,
SkColorType colorType)
First code I ever wrote for Skia haha :)

https://codereview.chromium.org/1641663002/diff/60001/tools/dm_flags.py
File tools/dm_flags.py (left):

https://codereview.chromium.org/1641663002/diff/60001/tools/dm_flags.py#oldco...
tools/dm_flags.py:167: if 'x86' in bot and not 'x86-64' in bot:
There is still a risk of this bot running out of memory (these are disabled for
Codec too).  I'm fine if we want to see if removing ImageDecoder solves the
problem or if we want to leave these tests in the blacklist.

[scroggo, 2016-01-27 16:13:24]

https://codereview.chromium.org/1641663002/diff/60001/tools/dm_flags.py
File tools/dm_flags.py (left):

https://codereview.chromium.org/1641663002/diff/60001/tools/dm_flags.py#oldco...
tools/dm_flags.py:167: if 'x86' in bot and not 'x86-64' in bot:
On 2016/01/27 15:52:37, msarett wrote:
> There is still a risk of this bot running out of memory (these are disabled
for
> Codec too).  I'm fine if we want to see if removing ImageDecoder solves the
> problem or if we want to leave these tests in the blacklist.

Ah, my mistake. "image" used to mean "SkImageDecoder", while "codec" (I think?)
meant SkCodec. But I forgot that they changed. I'll leave this here. If we
decide to remove it, we can do so separately.

[scroggo, 2016-01-27 16:13:40]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-01-27 16:13:40]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/1641663002/#ps80001
(title: "Reblacklist some interlaced images")

[commit-bot: I haz the power, 2016-01-27 16:13:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1641663002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1641663002/80001

[commit-bot: I haz the power, 2016-01-27 16:26:46]

Description was changed from

==========
Stop testing SkImageDecoder in DM/nanobench

We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Stop testing SkImageDecoder in DM/nanobench

We have already used it for comparison, and are switching forward
to using SkCodec. This also allows us to simplify the code for checking
the extensions we support for images.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/0edf1693dfd8360f5b8256e0700c2240854c010f
==========

[commit-bot: I haz the power, 2016-01-27 16:26:46]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/0edf1693dfd8360f5b8256e0700c2240854c010f