Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2090)

Unified Diff: bench/nanobench.cpp

Issue 1641663002: Stop testing SkImageDecoder in DM/nanobench (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Reblacklist some interlaced images Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bench/DecodingBench.cpp ('k') | dm/DM.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/nanobench.cpp
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index cfedc52379d21f5b39a255696cdcd3a5b71aa369..d6c4c596c1a6d59fb5e4a0242f8be7d3fd7f762b 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -14,7 +14,6 @@
#include "CodecBench.h"
#include "CodecBenchPriv.h"
#include "CrashHandler.h"
-#include "DecodingBench.h"
#include "GMBench.h"
#include "ProcStats.h"
#include "ResultsWriter.h"
@@ -561,7 +560,6 @@ public:
, fCurrentSKP(0)
, fCurrentUseMPD(0)
, fCurrentCodec(0)
- , fCurrentImage(0)
, fCurrentBRDImage(0)
, fCurrentColorType(0)
, fCurrentAlphaType(0)
@@ -812,29 +810,6 @@ public:
fCurrentColorType = 0;
}
- // Run the DecodingBenches
- for (; fCurrentImage < fImages.count(); fCurrentImage++) {
- fSourceType = "image";
- fBenchType = "skimagedecoder";
- const SkString& path = fImages[fCurrentImage];
- if (SkCommandLineFlags::ShouldSkip(FLAGS_match, path.c_str())) {
- continue;
- }
- while (fCurrentColorType < fColorTypes.count()) {
- SkColorType colorType = fColorTypes[fCurrentColorType];
- fCurrentColorType++;
- // Check if the image decodes to the right color type
- // before creating the benchmark
- SkBitmap bitmap;
- if (SkImageDecoder::DecodeFile(path.c_str(), &bitmap,
- colorType, SkImageDecoder::kDecodePixels_Mode)
- && bitmap.colorType() == colorType) {
- return new DecodingBench(path, colorType);
- }
- }
- fCurrentColorType = 0;
- }
-
// Run the BRDBenches
// We will benchmark multiple BRD strategies.
static const struct {
@@ -993,7 +968,6 @@ private:
int fCurrentSKP;
int fCurrentUseMPD;
int fCurrentCodec;
- int fCurrentImage;
int fCurrentBRDImage;
int fCurrentColorType;
int fCurrentAlphaType;
« no previous file with comments | « bench/DecodingBench.cpp ('k') | dm/DM.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698