Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1641623002: Revert of command_buffer: Enable gl path rendering by default (Closed)

Created:
4 years, 11 months ago by magjed_chromium
Modified:
4 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of command_buffer: Enable gl path rendering by default (patchset #1 id:1 of https://codereview.chromium.org/1626363002/ ) Reason for revert: This CL is causing the Linux Release (NVIDIA) builder to fail: https://build.chromium.org/p/chromium.gpu/builders/Linux%20Release%20(NVIDIA) It fails on step gl_tests on test GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0 with this error message: GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0: [13969:13969:0126/235302:15239455268986:ERROR:buffer_manager.cc(361)] [GroupMarkerNotSet(crbug.com/242999)!:C84AD1F190090000]GL ERROR :GL_INVALID_ENUM : glBufferData: <- error from previous GL command ../../gpu/command_buffer/tests/gl_test_utils.cc:31: Failure Value of: error Actual: 1280 Expected: static_cast<GLenum>(0) Which is: 0 GL ERROR in no errors at line 52 : 1280 Original issue's description: > command_buffer: Enable gl path rendering by default > > Enable gl path rendering by default if it is supported by the > hardware. > > Skia will use it when GPU rasterization MSAA codepath is used. > > BUG=344330 > > Committed: https://crrev.com/3f4b630297d744ce825a18f167550c10892e7e76 > Cr-Commit-Position: refs/heads/master@{#371753} TBR=vmiura@chromium.org,bsalomon@google.com,zmo@google.com,senorblanco@chromium.org,zmo@chromium.org,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=344330 Committed: https://crrev.com/f3fdb38602a27e727fd28201bd3dd12f22a090a2 Cr-Commit-Position: refs/heads/master@{#371767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M gpu/command_buffer/service/feature_info.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_extensions.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_chromium_framebuffer_mixed_samples_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_chromium_path_rendering_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
magjed_chromium
Created Revert of command_buffer: Enable gl path rendering by default
4 years, 11 months ago (2016-01-27 10:30:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641623002/1
4 years, 11 months ago (2016-01-27 10:30:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641623002/1
4 years, 11 months ago (2016-01-27 10:32:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 10:34:24 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 10:35:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3fdb38602a27e727fd28201bd3dd12f22a090a2
Cr-Commit-Position: refs/heads/master@{#371767}

Powered by Google App Engine
This is Rietveld 408576698