Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 1641623002: Revert of command_buffer: Enable gl path rendering by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index 7675f6650c9c56710d8cff1fec4b0b73f2a54ab1..9edd93f1f07cabb74fd0cf7fecff11364720fb72 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -1272,8 +1272,18 @@
EXPECT_FALSE(info_->feature_flags().blend_equation_advanced_coherent);
}
+TEST_P(FeatureInfoTest, InitializeCHROMIUM_path_rendering_no_cmdline_switch) {
+ SetupInitExpectationsWithGLVersion(
+ "GL_ARB_compatibility GL_NV_path_rendering GL_EXT_direct_state_access",
+ "", "4.3");
+ EXPECT_FALSE(info_->feature_flags().chromium_path_rendering);
+ EXPECT_THAT(info_->extensions(),
+ Not(HasSubstr("GL_CHROMIUM_path_rendering")));
+}
+
TEST_P(FeatureInfoTest, InitializeCHROMIUM_path_rendering) {
base::CommandLine command_line(0, NULL);
+ command_line.AppendSwitch(switches::kEnableGLPathRendering);
SetupInitExpectationsWithGLVersionAndCommandLine(
"GL_ARB_compatibility GL_NV_path_rendering GL_EXT_direct_state_access",
"", "4.3", command_line);
@@ -1283,6 +1293,7 @@
TEST_P(FeatureInfoTest, InitializeCHROMIUM_path_rendering2) {
base::CommandLine command_line(0, NULL);
+ command_line.AppendSwitch(switches::kEnableGLPathRendering);
SetupInitExpectationsWithGLVersionAndCommandLine(
"GL_NV_path_rendering", "", "OpenGL ES 3.1", command_line);
EXPECT_TRUE(info_->feature_flags().chromium_path_rendering);
@@ -1291,6 +1302,7 @@
TEST_P(FeatureInfoTest, InitializeNoCHROMIUM_path_rendering) {
base::CommandLine command_line(0, NULL);
+ command_line.AppendSwitch(switches::kEnableGLPathRendering);
SetupInitExpectationsWithGLVersionAndCommandLine("GL_ARB_compatibility", "",
"4.3", command_line);
EXPECT_FALSE(info_->feature_flags().chromium_path_rendering);
@@ -1300,6 +1312,7 @@
TEST_P(FeatureInfoTest, InitializeNoCHROMIUM_path_rendering2) {
base::CommandLine command_line(0, NULL);
+ command_line.AppendSwitch(switches::kEnableGLPathRendering);
SetupInitExpectationsWithGLVersionAndCommandLine(
"GL_ARB_compatibility GL_NV_path_rendering", "", "4.3", command_line);
EXPECT_FALSE(info_->feature_flags().chromium_path_rendering);
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_extensions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698