Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1641573002: Fix layout test for Event.scoped (Closed)

Created:
4 years, 11 months ago by yuzuchan
Modified:
4 years, 10 months ago
Reviewers:
kojii, hayato, yuzusan, kochi
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix layout test for Event.scoped Fix the layout test related to this CL : https://codereview.chromium.org/1586563005/ Changes are made so that the test will handle the cases where events do not happen. BUG=531990, 575042 Committed: https://crrev.com/c27e76c7d430f4ed19298d25fde0db4ebd5cb7f4 Cr-Commit-Position: refs/heads/master@{#372627}

Patch Set 1 #

Patch Set 2 : Fix styling #

Patch Set 3 : Fix Styling #

Total comments: 8

Patch Set 4 : Use async_test and deepPath() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -49 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html View 1 2 3 1 chunk +36 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
yuzuchan
4 years, 11 months ago (2016-01-28 06:16:37 UTC) #3
kochi
https://codereview.chromium.org/1641573002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html File third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html (right): https://codereview.chromium.org/1641573002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html#newcode5 third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html:5: <img id="img" src="../../images/resources/test-load.jpg" onload="loadScopeTest()" onerror="imgLoadTest()"> There's still a chance ...
4 years, 11 months ago (2016-01-28 07:01:12 UTC) #4
yuzuchan
https://codereview.chromium.org/1641573002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html File third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html (right): https://codereview.chromium.org/1641573002/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html#newcode5 third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html:5: <img id="img" src="../../images/resources/test-load.jpg" onload="loadScopeTest()" onerror="imgLoadTest()"> On 2016/01/28 07:01:12, kochi ...
4 years, 10 months ago (2016-02-01 08:42:49 UTC) #5
hayato
lgtm
4 years, 10 months ago (2016-02-01 09:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641573002/60001
4 years, 10 months ago (2016-02-01 09:05:56 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-01 09:48:45 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 09:50:06 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c27e76c7d430f4ed19298d25fde0db4ebd5cb7f4
Cr-Commit-Position: refs/heads/master@{#372627}

Powered by Google App Engine
This is Rietveld 408576698