Add Event.scoped

Add scoped flag to Event.

Spec is described here: http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042
Committed: https://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c
Cr-Commit-Position: refs/heads/master@{#371747}

[yuzuchan, 2016-01-14 09:22:47]

Description was changed from

==========
Add Event.scoped()
R=hayato@chromium.org
BUG=
==========

to

==========
Add Event.scoped()
R=hayato@chromium.org
BUG=
==========

[yuzuchan, 2016-01-14 09:22:48]

yuzus@chromium.org changed reviewers:
+ kochi@chromium.org, kojii@chromium.org

[hayato, 2016-01-15 03:59:52]

Looks promising. Thank you!

My comments are for patch set 1. Some of them are obsolete, I guess. :)

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html
(right):

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:26:
img.onload = function (e) {
Nit: Remove a space between "function" and "(e)".

e.g. img.onload = function(e) {

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:27:
test(function () {
Nit: "function ()" => "function()"

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:46:
if (event.type == 'load'){
Nit. One space is required. between ")" and "{"

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:47:
if(event.currentTarget){
Ditto. One space is required. ") {"

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:47:
if(event.currentTarget){
I guess event.currentTarget is always non-null.
Can you remove this "if (event.currentTarget)" check?

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:50:
}else if (event.type == 'error'){
Ditto:
- "} else if"
- ") {"

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:56:
if (eventCount == 3) {
This is assuming that "load" event happens before "error" event, right?

If "error" event happens before "load" event, this test would *pass* wrongly
even if "load" event does not stop, ignoring that eventRecord is called 4 times
in total.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:57:
test(function () {
Nit: "function ()" => "function()"

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:58:
assert_array_equals(resultTrusted,['target']);
Nit: One space is required after ","

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/Event.cpp (right):

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.cpp:39: if (eventType ==
EventTypeNames::abort
You do not have to use "if (xxx) { return true; } return false;" here.

"return xxx" is good enough here.

e.g.
return eventType == EventTypeNames::abort
    || eventType == EventTypeNames::change
    || ...;

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/Event.idl (right):

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:48: readonly attribute boolean
scoped;
You have to guard this by [RuntimeEnabled=ShadowDOMV1].

The description of TODO can be simple: "TODO(yuzus): Measure the usage"

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:53: // be:
Unintentional change?

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:55: //  - DOMHighResTimeStamp
(i.e. double):  HighResEventTimeStamp REF is
Ditto.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:66: [Default=Undefined] optional
boolean cancelable) ;
Ditto.

[yuzuchan, 2016-01-15 05:32:26]

yuzus@chromium.org changed reviewers:
+ yuzus@chromium.org

[yuzuchan, 2016-01-15 05:32:27]

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html
(right):

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:26:
img.onload = function (e) {
On 2016/01/15 03:59:52, hayato wrote:
> Nit: Remove a space between "function" and "(e)".
> 
> e.g. img.onload = function(e) {

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:27:
test(function () {
On 2016/01/15 03:59:52, hayato wrote:
> Nit: "function ()" => "function()"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:46:
if (event.type == 'load'){
On 2016/01/15 03:59:52, hayato wrote:
> Nit. One space is required. between ")" and "{"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:46:
if (event.type == 'load'){
On 2016/01/15 03:59:52, hayato wrote:
> Nit. One space is required. between ")" and "{"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:46:
if (event.type == 'load'){
On 2016/01/15 03:59:52, hayato wrote:
> Nit. One space is required. between ")" and "{"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:47:
if(event.currentTarget){
On 2016/01/15 03:59:52, hayato wrote:
> I guess event.currentTarget is always non-null.
> Can you remove this "if (event.currentTarget)" check?

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:47:
if(event.currentTarget){
On 2016/01/15 03:59:52, hayato wrote:
> Ditto. One space is required. ") {"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:50:
}else if (event.type == 'error'){
On 2016/01/15 03:59:52, hayato wrote:
> Ditto:
> - "} else if"
> - ") {"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:56:
if (eventCount == 3) {
Very true. Fixed in Patch 3. Done.

On 2016/01/15 03:59:52, hayato wrote:
> This is assuming that "load" event happens before "error" event, right?
> 
> If "error" event happens before "load" event, this test would *pass* wrongly
> even if "load" event does not stop, ignoring that eventRecord is called 4
times
> in total.
> 
>

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:57:
test(function () {
On 2016/01/15 03:59:52, hayato wrote:
> Nit: "function ()" => "function()"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/shadow/event-scoped-user-setting-on-creation.html:58:
assert_array_equals(resultTrusted,['target']);
On 2016/01/15 03:59:52, hayato wrote:
> Nit: One space is required after ","

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/Event.cpp (right):

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.cpp:39: if (eventType ==
EventTypeNames::abort
On 2016/01/15 03:59:52, hayato wrote:
> You do not have to use "if (xxx) { return true; } return false;" here.
> 
> "return xxx" is good enough here.
> 
> e.g.
> return eventType == EventTypeNames::abort
>     || eventType == EventTypeNames::change
>     || ...;

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/events/Event.idl (right):

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:48: readonly attribute boolean
scoped;
On 2016/01/15 03:59:52, hayato wrote:
> You have to guard this by [RuntimeEnabled=ShadowDOMV1].
> 
> The description of TODO can be simple: "TODO(yuzus): Measure the usage"

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:53: // be:
On 2016/01/15 03:59:52, hayato wrote:
> Unintentional change?

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:55: //  - DOMHighResTimeStamp
(i.e. double):  HighResEventTimeStamp REF is
On 2016/01/15 03:59:52, hayato wrote:
> Ditto.

Done.

https://codereview.chromium.org/1586563005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/events/Event.idl:66: [Default=Undefined] optional
boolean cancelable) ;
On 2016/01/15 03:59:52, hayato wrote:
> Ditto.

Done.

[kochi, 2016-01-15 06:51:16]

For tests under LayoutTests/imported,
please mark those tests which fail as [Failure] in
LayoutTest/TestExpectations file.

https://codereview.chromium.org/1586563005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.cpp (right):

https://codereview.chromium.org/1586563005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.cpp:51: : Event("", false, false)
This line should Event("", false, false, false)

to avoid calling defaultScopedFromEventType("").

[kochi, 2016-01-15 06:55:19]

On 2016/01/15 06:51:16, kochi wrote:
> For tests under LayoutTests/imported,
> please mark those tests which fail as [Failure] in
> LayoutTest/TestExpectations file.


FYI, these tests are "imported" from https://github.com/w3c/web-platform-tests
and local changes (in Blink source tree) aren't automatically reflected
back to the GitHub repository (the import procedure is one-way, thus
the changes should be applied in upstream GitHub first then import them again).

Until the fixed tests are imported, we use the TestExpectations file to mark
temporarily failing tests as "[ Failure ]".

[yuzuchan, 2016-01-15 07:52:38]

Done. Thank you!
On 2016/01/15 06:55:19, kochi wrote:
> On 2016/01/15 06:51:16, kochi wrote:
> > For tests under LayoutTests/imported,
> > please mark those tests which fail as [Failure] in
> > LayoutTest/TestExpectations file.
> 
> 
> FYI, these tests are "imported" from https://github.com/w3c/web-platform-tests
> and local changes (in Blink source tree) aren't automatically reflected
> back to the GitHub repository (the import procedure is one-way, thus
> the changes should be applied in upstream GitHub first then import them
again).
> 
> Until the fixed tests are imported, we use the TestExpectations file to mark
> temporarily failing tests as "[ Failure ]".

[yuzuchan, 2016-01-15 07:53:02]

https://codereview.chromium.org/1586563005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.cpp (right):

https://codereview.chromium.org/1586563005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.cpp:51: : Event("", false, false)
On 2016/01/15 06:51:16, kochi wrote:
> This line should Event("", false, false, false)
> 
> to avoid calling defaultScopedFromEventType("").

Done.

[kochi, 2016-01-18 08:39:50]

https://codereview.chromium.org/1586563005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventInit.idl (right):

https://codereview.chromium.org/1586563005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventInit.idl:10: boolean scoped = false;
You also need [RuntimeEnabled=ShadowDOMV1, MeasureAs=EventScoped] 
here not to expose this accidentally to the web.

[kochi, 2016-01-18 08:53:31]

On 2016/01/18 08:39:50, kochi wrote:
>
https://codereview.chromium.org/1586563005/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/events/EventInit.idl (right):
> 
>
https://codereview.chromium.org/1586563005/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/events/EventInit.idl:10: boolean scoped =
false;
> You also need [RuntimeEnabled=ShadowDOMV1, MeasureAs=EventScoped] 
> here not to expose this accidentally to the web.

Please also update the description of this CL.
As the description will be recorded as a log for git repository,
it's important to have a good description for future reference.

[yuzusan, 2016-01-19 04:36:09]

Description was changed from

==========
Add Event.scoped()
R=hayato@chromium.org
BUG=
==========

to

==========
Add scoped flag to Event.

Spec is described here:
http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag
is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990
==========

[yuzusan, 2016-01-19 06:10:28]

https://codereview.chromium.org/1586563005/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/EventInit.idl (right):

https://codereview.chromium.org/1586563005/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/EventInit.idl:10: boolean scoped = false;
On 2016/01/18 08:39:50, kochi wrote:
> You also need [RuntimeEnabled=ShadowDOMV1, MeasureAs=EventScoped] 
> here not to expose this accidentally to the web.

Done.

[yuzusan, 2016-01-19 11:20:04]

Description was changed from

==========
Add scoped flag to Event.

Spec is described here:
http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag
is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990
==========

to

==========
Add scoped flag to Event.

Spec is described here:
http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag
is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042
==========

[hayato, 2016-01-21 09:51:41]

I think you have to update LayoutTests/webexposed/ also in this CL, as you did
in https://codereview.chromium.org/1577163003/

Could you check it again?

https://codereview.chromium.org/1586563005/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/EventInit.idl (right):

https://codereview.chromium.org/1586563005/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/EventInit.idl:10:
[RuntimeEnabled=ShadowDOMV1, MeasureAs=EventScoped] boolean scoped = false;
Could you remove "MeasureAs=EventScoped" from here?
I guess that "MeasureAs" does not work for a dictionary member.

[yuzuchan, 2016-01-22 05:44:35]

https://codereview.chromium.org/1586563005/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/EventInit.idl (right):

https://codereview.chromium.org/1586563005/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/EventInit.idl:10:
[RuntimeEnabled=ShadowDOMV1, MeasureAs=EventScoped] boolean scoped = false;
On 2016/01/21 09:51:40, hayato wrote:
> Could you remove "MeasureAs=EventScoped" from here?
> I guess that "MeasureAs" does not work for a dictionary member.

Done.

[hayato, 2016-01-22 07:16:25]

lgtm

https://codereview.chromium.org/1586563005/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt
(right):

https://codereview.chromium.org/1586563005/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:86:
FAIL successfullyParsed should be true. Was false.
Looks something is wrong. Could you check this?

https://codereview.chromium.org/1586563005/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/events/Event.cpp (right):

https://codereview.chromium.org/1586563005/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/events/Event.cpp:90: : Event(eventType,
initializer.bubbles(), initializer.cancelable(), initializer.scoped())
Maybe we might want to measure the usage of "scoped" in two places:

1. "scoped" is used in an event's constructor, e.g.  "new Event{scoped: true}"
2. Users access event.scoped property. e.g "console.log(event.scoped)"

If we would like to measure the usage of 1), we can do it here later.

[yuzuchan, 2016-01-25 07:23:49]

https://codereview.chromium.org/1586563005/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt
(right):

https://codereview.chromium.org/1586563005/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:86:
FAIL successfullyParsed should be true. Was false.
Found out that I was missing a semicolon. After adding it, this test is PASSing.

On 2016/01/22 07:16:25, hayato wrote:
> Looks something is wrong. Could you check this?

[yuzuchan, 2016-01-25 07:23:59]

The CQ bit was checked by yuzus@chromium.org

[yuzuchan, 2016-01-25 07:23:59]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1586563005/#ps160001
(title: "Add a missing semicolon")

[commit-bot: I haz the power, 2016-01-25 07:24:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586563005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586563005/160001

[commit-bot: I haz the power, 2016-01-25 08:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 08:03:21]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kochi, 2016-01-25 08:28:52]

On 2016/01/25 08:03:21, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Aside from mac_chromium_rel_ng (which failed at patch phase),
linux_chromium_rel_ng
failed for events-stopped-at-shadow-boundary.html, as if the fix from patchset 8
to
patchset 9 was not included.

https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...

Yuzu, could you look into it again?

[yuzuchan, 2016-01-27 05:11:11]

On 2016/01/25 08:28:52, kochi wrote:
> On 2016/01/25 08:03:21, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
> 
> Aside from mac_chromium_rel_ng (which failed at patch phase),
> linux_chromium_rel_ng
> failed for events-stopped-at-shadow-boundary.html, as if the fix from patchset
8
> to
> patchset 9 was not included.
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_r...
> 
> Yuzu, could you look into it again?

Found out that error events created by users in the layout test were bubbling up
due to the change, and failing the test by raising an error.
I removed the error from the test.

[yuzuchan, 2016-01-27 05:50:45]

The CQ bit was checked by yuzus@chromium.org

[yuzuchan, 2016-01-27 05:50:45]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1586563005/#ps180001
(title: "Remove error from test case as it bubbles up and fails test\")

[commit-bot: I haz the power, 2016-01-27 05:51:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586563005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586563005/180001

[kochi, 2016-01-27 06:02:16]

https://codereview.chromium.org/1586563005/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html
(right):

https://codereview.chromium.org/1586563005/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/shadow/events-stopped-at-shadow-boundary.html:54:
var events = ['abort', 'select', 'change', 'reset', 'resize', 'scroll',
'selectstart', 'load', 'click'];
For the record, the 'error' event bubbles up out of the shadow root,
it will be caught by the test runner as an error, and removed from this list.

https://codereview.chromium.org/1586563005/diff/180001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html
(right):

https://codereview.chromium.org/1586563005/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html:28:
assert_equals(e.scoped, true);
Can you guarantee that onload event ever happens in this test?
i.e. if HTML parser starts loading the image just after parsing on line 5,
image loading might be complete before JavaScript interpreter comes to this
line?

https://codereview.chromium.org/1586563005/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html:52:
assert_equals(event.currentTarget.id, 'target');
The test above (assert_true(false) is okay in the event handler, because
it catches a "should never happen" condition, and once the test is hit,
the whole test fails.

On the other hand, this test, if properly recordEvent() is invoked via
the expected event, will pass, but this also passes when such event
didn't happen.

https://codereview.chromium.org/1586563005/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html:57:
resultNonTrusted.push(event.currentTarget.id);
Why this 'error' event did not cause the same error as in the other test,
to cause "FAIL successfullyParsed..." ? (because this uses testharness, not
js-test.js?)

https://codereview.chromium.org/1586563005/diff/180001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/dom/shadow/scoped-events-by-ua-stopped.html:62:
done();
done() can only be used in async_test().

[commit-bot: I haz the power, 2016-01-27 06:22:58]

Description was changed from

==========
Add scoped flag to Event.

Spec is described here:
http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag
is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042
==========

to

==========
Add scoped flag to Event.

Spec is described here:
http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag
is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042
==========

[commit-bot: I haz the power, 2016-01-27 06:22:59]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-01-27 06:23:58]

Description was changed from

==========
Add scoped flag to Event.

Spec is described here:
http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag
is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042
==========

to

==========
Add scoped flag to Event.

Spec is described here:
http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag
is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042

Committed: https://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c
Cr-Commit-Position: refs/heads/master@{#371747}
==========

[commit-bot: I haz the power, 2016-01-27 06:24:00]

Patchset 10 (id:??) landed as
https://crrev.com/e3f3112453d171c88fd0f06b4c8196228f47780c
Cr-Commit-Position: refs/heads/master@{#371747}