Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: components/ssl_errors/error_classification.cc

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Follows rename. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ssl_errors/error_classification.cc
diff --git a/components/ssl_errors/error_classification.cc b/components/ssl_errors/error_classification.cc
index 75104f85965e1f4b7c51d0a0608d0cf75a763493..843fdc6910a824b978e70b4eb9f1c3db8e86712e 100644
--- a/components/ssl_errors/error_classification.cc
+++ b/components/ssl_errors/error_classification.cc
@@ -212,11 +212,7 @@ bool IsUserClockInThePast(const base::Time& time_now) {
if (!g_testing_build_time.Get().is_null()) {
build_time = g_testing_build_time.Get();
} else {
-#if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)
agl 2016/01/29 21:46:46 This (and below) needs careful consideration about
- return false;
-#else
build_time = base::GetBuildTime();
-#endif
}
if (time_now < build_time - base::TimeDelta::FromDays(2))
@@ -229,11 +225,7 @@ bool IsUserClockInTheFuture(const base::Time& time_now) {
if (!g_testing_build_time.Get().is_null()) {
build_time = g_testing_build_time.Get();
} else {
-#if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)
- return false;
-#else
build_time = base::GetBuildTime();
-#endif
}
if (time_now > build_time + base::TimeDelta::FromDays(365))

Powered by Google App Engine
This is Rietveld 408576698