net/cert/ct_policy_enforcer.cc - Issue 1641413002: Makes GetBuildTime behave identically on all build types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/ct_policy_enforcer.cc

Issue 1641413002: Makes GetBuildTime behave identically on all build types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Follows rename. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ssl_errors/error_classification.cc ('K') | « components/ssl_errors/error_classification.cc ('k') | net/http/transport_security_state.cc » ('j') | net/http/transport_security_state.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/cert/ct_policy_enforcer.cc

diff --git a/net/cert/ct_policy_enforcer.cc b/net/cert/ct_policy_enforcer.cc

index d9c92421bf86e0ba4d7d101e07268769ad1dd137..32181d456e39a7807b6c5b6caebaa23c1932f1eb 100644

--- a/net/cert/ct_policy_enforcer.cc

+++ b/net/cert/ct_policy_enforcer.cc

@@ -37,13 +37,9 @@ bool IsEmbeddedSCT(const scoped_refptr<ct::SignedCertificateTimestamp>& sct) {

// built-in security information (e.g. CT Logs) is fresh enough.

// TODO(eranm): Move to base or net/base

bool IsBuildTimely() {

-#if defined(DONT_EMBED_BUILD_METADATA) && !defined(OFFICIAL_BUILD)

agl 2016/01/29 21:46:46 ditto.

- return true;

-#else

const base::Time build_time = base::GetBuildTime();

// We consider built-in information to be timely for 10 weeks.

return (base::Time::Now() - build_time).InDays() < 70 /* 10 weeks */;

-#endif

}

bool IsGoogleIssuedSCT(