Chromium Code Reviews| Index: base/build_time.h |
| diff --git a/base/build_time.h b/base/build_time.h |
| index 4f0abc381336641425dab76d4f1533a0041b22bb..3fdd43d25dcf57d7ab56c5bf28b4f09cb1a35c60 100644 |
| --- a/base/build_time.h |
| +++ b/base/build_time.h |
| @@ -10,17 +10,13 @@ |
| namespace base { |
| -// GetBuildTime returns the time at which the current binary was built. |
| +// GetBuildTime returns the time at which the current binary was built, |
| +// rounded to midnight at the start of the day. |
|
agl
2016/01/29 21:46:45
s/rounded/rounded down/
(Normal rounding would su
M-A Ruel
2016/01/30 02:58:14
of the day in the current time zone, since __DATE_
Zachary Forman
2016/02/01 07:28:30
Done. I've adjusted it to use the result of a pyth
|
| // |
| -// This uses the __DATE__ and __TIME__ macros, which don't trigger a rebuild |
| -// when they change. However, official builds will always be rebuilt from |
| -// scratch. |
| +// This uses the __DATE__ macro, which doesn't trigger a rebuild when it |
| +// changes. However, official builds will always be built from scratch. |
| // |
| -// Also, since __TIME__ doesn't include a timezone, this value should only be |
| -// considered accurate to a day. |
| -// |
| -// NOTE: This function is disabled except for the official builds, by default |
| -// the date returned is "Sep 02 2008 08:00:00 PST". |
| +// This value should only be considered accurate to a day. |
|
agl
2016/01/29 21:46:46
s/a day/36 hours/
If you're just to the east of t
Zachary Forman
2016/02/01 07:28:30
Done. I've made it always use the real time at UTC
|
| Time BASE_EXPORT GetBuildTime(); |
| } // namespace base |