Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1641383002: [Android WebView] Do not terminate WebView when second browser is started (Closed)

Created:
4 years, 10 months ago by mnaganov (inactive)
Modified:
4 years, 10 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Do not terminate WebView when second browser is started Still detect the situation when the app is creating WebView from two processes sharing the same data dir, but do not throw a RuntimeError, only print a warning. BUG=558377, 582146 Committed: https://crrev.com/d881bd2507c934240decdcbf2a5002716fe5b308 Cr-Commit-Position: refs/heads/master@{#372231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +2 lines, -3 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mnaganov (inactive)
4 years, 10 months ago (2016-01-28 23:59:20 UTC) #2
boliu
lgtm
4 years, 10 months ago (2016-01-29 00:02:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641383002/1
4 years, 10 months ago (2016-01-29 00:24:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 00:57:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:58:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d881bd2507c934240decdcbf2a5002716fe5b308
Cr-Commit-Position: refs/heads/master@{#372231}

Powered by Google App Engine
This is Rietveld 408576698