Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java

Issue 1641383002: [Android WebView] Do not terminate WebView when second browser is started (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
index 25f951fdfb95975882953cb5b0f4177b431ab629..dcf4e7c5464ed9ae6bc0785cf0679f8323fb7ede 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
@@ -13,10 +13,9 @@ import android.os.IBinder;
import android.os.Parcel;
import android.os.Process;
import android.os.RemoteException;
-import android.test.suitebuilder.annotation.LargeTest;
import org.chromium.android_webview.AwBrowserProcess;
-import org.chromium.base.test.util.Feature;
+import org.chromium.base.test.util.DisabledTest;
import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
@@ -42,15 +41,24 @@ public class AwSecondBrowserProcessTest extends AwTestBase {
super.tearDown();
}
- @LargeTest
- @Feature({"AndroidWebView"})
+ /*
+ * @LargeTest
+ * @Feature({"AndroidWebView"})
+ * See crbug.com/582146. We can't test that creating second browser
+ * process succeeds either, because in debug it will crash due to an assert
+ * in the SQL DB code.
+ */
+ @DisabledTest
public void testCreatingSecondBrowserProcessFails() throws Throwable {
startSecondBrowserProcess();
assertFalse(tryStartingBrowserProcess());
}
- @LargeTest
- @Feature({"AndroidWebView"})
+ /*
+ * @LargeTest
+ * @Feature({"AndroidWebView"})
+ */
+ @DisabledTest
public void testLockCleanupOnProcessShutdown() throws Throwable {
startSecondBrowserProcess();
assertFalse(tryStartingBrowserProcess());
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698