Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1641003002: [exp] ash: Ash in Mus.

Created:
4 years, 10 months ago by sadrul
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews, rjkroege, kalyank, sadrul, oshima+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[exp] ash: Ash in Mus. ...

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : tot-merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+687 lines, -164 lines) Patch
M ash/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_ash.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_ozone.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M ash/host/transformer_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/host/transformer_helper.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
A ash/mus/wm/BUILD.gn View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A + ash/mus/wm/DEPS View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + ash/mus/wm/accelerator_registrar_impl.h View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
A + ash/mus/wm/accelerator_registrar_impl.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
A + ash/mus/wm/main.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + ash/mus/wm/non_client_frame_controller.h View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
A ash/mus/wm/non_client_frame_controller.cc View 1 2 1 chunk +185 lines, -0 lines 0 comments Download
A + ash/mus/wm/window_manager_application.h View 1 2 6 chunks +18 lines, -59 lines 0 comments Download
A ash/mus/wm/window_manager_application.cc View 1 2 1 chunk +289 lines, -0 lines 0 comments Download
A + ash/mus/wm/window_manager_impl.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
A + ash/mus/wm/window_manager_impl.cc View 1 2 8 chunks +18 lines, -27 lines 0 comments Download
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_views.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M components/mus/ws/server_window_surface_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/mus/ws/window_finder.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/shell/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mash/shell/shell_application_delegate.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.cc View 2 chunks +1 line, -6 lines 0 comments Download
M ui/views/mus/aura_init.cc View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1645503004 Patch 1
Issue 1645503004 Patch 20001
Issue 1645503004 Patch 40001
Issue 1645503004 Patch 60001
Issue 1645503004 Patch 80001
Issue 1645503004 Patch 100001
Issue 1645503004 Patch 120001

Messages

Total messages: 2 (2 generated)
sadrul
Description was changed from ========== [exp] ash: Ash in Mus. ... ========== to ========== [exp] ...
4 years, 10 months ago (2016-01-28 16:53:54 UTC) #1
sadrul
4 years, 10 months ago (2016-01-29 18:25:45 UTC) #2 
Description was changed from

==========
[exp] ash: Ash in Mus.


You need to revert https://codereview.chromium.org/1640253003 to fix
stacking issue.

...
==========

to

==========
[exp] ash: Ash in Mus.

...
==========

Powered by Google App Engine
This is Rietveld 408576698