Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1640253003: Makes resolving ids work correctly in new world (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes resolving ids work correctly in new world https://codereview.chromium.org/1639223003/ makes it so clients can use whatever ids they want for windows. This means when surfaces resolve ids they need to resolve the id against the client that submitted the frame. This patch does that. BUG=566155 TEST=covered by tests R=fsamuel@chromium.org Committed: https://crrev.com/87d530d83939424412d07ac5c7d317c0c27d82dd Cr-Commit-Position: refs/heads/master@{#371956}

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : merge to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M components/mus/ws/connection_manager.h View 2 1 chunk +4 lines, -0 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 2 1 chunk +16 lines, -0 lines 0 comments Download
M components/mus/ws/server_window_delegate.h View 1 3 chunks +13 lines, -0 lines 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
M components/mus/ws/test_server_window_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/mus/ws/test_server_window_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/mus/ws/window_finder.cc View 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
sky
4 years, 10 months ago (2016-01-27 23:55:12 UTC) #1
Fady Samuel
lgtm
4 years, 10 months ago (2016-01-28 00:19:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640253003/40001
4 years, 10 months ago (2016-01-28 00:57:02 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-01-28 01:41:25 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/87d530d83939424412d07ac5c7d317c0c27d82dd Cr-Commit-Position: refs/heads/master@{#371956}
4 years, 10 months ago (2016-01-28 02:05:09 UTC) #8
sadrul
Ono. This ended up breaking https://codereview.chromium.org/1647933002/ :o
4 years, 10 months ago (2016-01-28 16:54:40 UTC) #9
sadrul
4 years, 10 months ago (2016-01-28 17:05:53 UTC) #10
Message was sent while issue was closed.
On 2016/01/28 16:54:40, sadrul wrote:
> Ono. This ended up breaking https://codereview.chromium.org/1647933002/ :o

eek, actually breaks https://codereview.chromium.org/1641003002/

Powered by Google App Engine
This is Rietveld 408576698