Docserver manifest follow up (rewrite)

chrome/common/extensions/docs/server2/manifest_data_source.py

Index: chrome/common/extensions/docs/server2/manifest_data_source.py
diff --git a/chrome/common/extensions/docs/server2/manifest_data_source.py b/chrome/common/extensions/docs/server2/manifest_data_source.py
index a10f41c74e00f7e02039183ec5cc5bc81b80b96e..5d1fea77a33a1a317a9507deb24537c5b9369ec5 100644
--- a/chrome/common/extensions/docs/server2/manifest_data_source.py
+++ b/chrome/common/extensions/docs/server2/manifest_data_source.py
@@ -17,7 +17,7 @@ def _ListifyAndSortDocs(properties, platform):
     '''
     levels = ('required', 'recommended', 'only_one', 'optional')
 
-    return (levels.index(item.get('level', 'optional')), item['name'])
+    return (levels.index(item.get('level', 'optional')), item.name)
 
   def convert_and_sort(properties):
     for key, value in properties.items():
@@ -36,6 +36,7 @@ def _ListifyAndSortDocs(properties, platform):
 
     return sorted(properties.values(), key=sort_key)
 
+  # Fix the 'name' manifest property's example.

[not at google - send to devlin, 2013/08/05 22:23:49]

I don't know what this means, can you give some context?

   name = properties['name']
   name['example'] = name['example'].replace('{{title}}', platform.capitalize())
 
@@ -82,7 +83,7 @@ def _RestructureChildren(features):
   children can have children.
   '''
   def add_child(features, parent, child_name, value):
-    value['name'] = child_name
+    value.name = child_name

[not at google - send to devlin, 2013/08/05 22:23:49]

So IIRC from our email, the purpose of storing the internals of the Feature as a
dict was mostly for easy merging, but also to avoid having to parse out a whole
bunch of things that we'll never need.

I.e. more an implementation detail than an interface detail.

This was one of the use cases, where we were going to return a new Feature based
on firstly mutating some dictionaries, then creating a feature from them like
that.

If Feature had a method like ToDict() then that'd be a starting point.

     if not 'children' in features[parent]:
       features[parent]['children'] = {}
     features[parent]['children'][child_name] = value