Docserver manifest follow up (rewrite)

chrome/common/extensions/docs/server2/manifest_data_source.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 
 from features_model import FeaturesModel
 from third_party.json_schema_compiler.json_parse import Parse
 
 def _ListifyAndSortDocs(properties, platform):
   '''Convert docs into lists and sort them, recursively such that children
   lists are also sorted, first by level, then by name.
   '''
   def sort_key(item):
     '''Key function to sort items primarily by level (according to index into
     levels) then subsort by name.
     '''
     levels = ('required', 'recommended', 'only_one', 'optional')
 
-    return (levels.index(item.get('level', 'optional')), item['name'])
+    return (levels.index(item.get('level', 'optional')), item.name)
 
   def convert_and_sort(properties):
     for key, value in properties.items():
       if 'example' in value:
         value['has_example'] = True
         example = json.dumps(value['example'])
         if example == '{}':
           value['example'] = '{...}'
         elif example == '[]':
           value['example'] = '[...]'
         else:
           value['example'] = example
 
       if 'children' in value:
         properties[key]['children'] = convert_and_sort(value['children'])
 
     return sorted(properties.values(), key=sort_key)
 
+  # Fix the 'name' manifest property's example.

[not at google - send to devlin, 2013/08/05 22:23:49]

I don't know what this means, can you give some context?

   name = properties['name']
   name['example'] = name['example'].replace('{{title}}', platform.capitalize())
 
   return convert_and_sort(properties)
 
 def _AddLevelAnnotations(properties):
   '''Add level annotations to level groups in a manifest property list and
   child lists. Requeries a list of properties sorted by level, with children
   in sorted lists as well.
 
@@ skipping 26 matching lines @@
   annotate('required', properties)
   return properties
 
 def _RestructureChildren(features):
   '''Features whose names are of the form 'parent.child' are moved to be part
   of the 'parent' dictionary under the key 'children'. Names are changed to
   the 'child' section of the original name. Applied recursively so that
   children can have children.
   '''
   def add_child(features, parent, child_name, value):
-    value['name'] = child_name
+    value.name = child_name

[not at google - send to devlin, 2013/08/05 22:23:49]

So IIRC from our email, the purpose of storing the internals of the Feature as a
dict was mostly for easy merging, but also to avoid having to parse out a whole
bunch of things that we'll never need.

I.e. more an implementation detail than an interface detail.

This was one of the use cases, where we were going to return a new Feature based
on firstly mutating some dictionaries, then creating a feature from them like
that.

If Feature had a method like ToDict() then that'd be a starting point.

     if not 'children' in features[parent]:
       features[parent]['children'] = {}
     features[parent]['children'][child_name] = value
 
   def insert_children(features):
     for name in features.keys():
       if '.' in name:
         value = features.pop(name)
         parent, child_name = name.split('.', 1)
         add_child(features, parent, child_name, value)
@@ skipping 43 matching lines @@
     manifest_features = (
         FeaturesModel.FromJson(Parse(content)).MergeWith(manifest_json))
 
     return {
       'apps': for_templates(manifest_features, 'app'),
       'extensions': for_templates(manifest_features, 'extension')
     }
 
   def get(self, key):
     return self._cache.GetFromFile(self._features_path)[key]