Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/common/extensions/docs/templates/private/manifest_properties.html

Issue 16410002: Docserver manifest follow up (rewrite) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gen-manifest-try-2
Patch Set: Small URL change Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/templates/private/manifest_properties.html
diff --git a/chrome/common/extensions/docs/templates/private/manifest_properties.html b/chrome/common/extensions/docs/templates/private/manifest_properties.html
index 5637891991a237909372fa10b959c3b1a0ba5f8a..f4309db54750d289970b25a996c47990ac52867b 100644
--- a/chrome/common/extensions/docs/templates/private/manifest_properties.html
+++ b/chrome/common/extensions/docs/templates/private/manifest_properties.html
@@ -1,6 +1,11 @@
-{{#properties}}
+{{?annotation}}
+<em>// {{annotation}}</em>
+{{/annotation}}
not at google - send to devlin 2013/07/02 18:23:11 This needs to be on its own line, right? Does it h
jshumway 2013/07/24 17:40:07 Yep, it renders correctly because this partial is
{{?documentation}}
-"<a href="{{documentation}}">{{name}}</a>": <em>{{*example}}</em>{{^is_last}},{{/}}
-{{:documentation}}
-"{{name}}": ...{{^is_last}},{{/}}
-{{/documentation}}{{/properties}}
+"<a href="{{documentation}}">{{name}}</a>":{{:documentation}}
not at google - send to devlin 2013/07/02 18:23:11 closing {{:documentation}} on its own line
jshumway 2013/07/24 17:40:07 Because this partial is expanded inside <pre> tags
+"{{name}}":{{^subdoc}} ...{{/}}{{/documentation}}
+{{?subdoc}} {
+{{#subdoc}}
+ {{+partials.manifest_properties}}
+{{/}}
not at google - send to devlin 2013/07/02 18:23:11 This should be able to be: {{#subdoc +partials.ma
jshumway 2013/07/24 17:40:07 see above. fixed closing tag.
+}{{:subdoc}}{{?example}} {{*@.value}}{{/}}{{/}}{{^is_last}},{{/}}
not at google - send to devlin 2013/07/02 18:23:11 can the {{:subdoc}} here be on its own line? {{?e
jshumway 2013/07/24 17:40:07 same as above about own line, changed {{?example *

Powered by Google App Engine
This is Rietveld 408576698