chrome/common/extensions/docs/templates/private/manifest_properties.html - Issue 16410002: Docserver manifest follow up (rewrite)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/manifest_properties.html

Issue 16410002: Docserver manifest follow up (rewrite) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gen-manifest-try-2

Patch Set: Small URL change Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/templates/json/manifest.json ('K') | « chrome/common/extensions/docs/templates/private/manifest_example.html ('k') | chrome/common/extensions/docs/templates/public/apps/contentSecurityPolicy.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {{#properties}}	1 {{?annotation}}

	2 <em>// {{annotation}}</em>

	3 {{/annotation}}
	not at google - send to devlin 2013/07/02 18:23:11 This needs to be on its own line, right? Does it h This needs to be on its own line, right? Does it happen? jshumway 2013/07/24 17:40:07 Yep, it renders correctly because this partial is Show quoted text On 2013/07/02 18:23:11, kalman wrote: > This needs to be on its own line, right? Does it happen? Yep, it renders correctly because this partial is expanded inside <pre> tags.
2 {{?documentation}}	4 {{?documentation}}

3 "<a href="{{documentation}}">{{name}}</a>": <em>{{*example}}</em>{{^is_last}},{{ /}}	5 "<a href="{{documentation}}">{{name}}</a>":{{:documentation}}
	not at google - send to devlin 2013/07/02 18:23:11 closing {{:documentation}} on its own line closing {{:documentation}} on its own line jshumway 2013/07/24 17:40:07 Because this partial is expanded inside <pre> tags Show quoted text On 2013/07/02 18:23:11, kalman wrote: > closing {{:documentation}} on its own line Because this partial is expanded inside <pre> tags, the handlebar markup has to be in this unsightly form. A similar story for {{#subdocs}} below, which has some strange whitespace errors when changed to the {{#subdocs +partial... /}} form.
4 {{:documentation}}	6 "{{name}}":{{^subdoc}} ...{{/}}{{/documentation}}

5 "{{name}}": ...{{^is_last}},{{/}}	7 {{?subdoc}} {

6 {{/documentation}}{{/properties}}	8 {{#subdoc}}

	9 {{+partials.manifest_properties}}

	10 {{/}}
	not at google - send to devlin 2013/07/02 18:23:11 This should be able to be: {{#subdoc +partials.ma This should be able to be: {{#subdoc +partials.manifest_properties}} if not, the closing {{/}} needs subdoc jshumway 2013/07/24 17:40:07 see above. fixed closing tag. Show quoted text On 2013/07/02 18:23:11, kalman wrote: > This should be able to be: > > {{#subdoc +partials.manifest_properties}} > > if not, the closing {{/}} needs subdoc see above. fixed closing tag.
	11 }{{:subdoc}}{{?example}} {{*@.value}}{{/}}{{/}}{{^is_last}},{{/}}
	not at google - send to devlin 2013/07/02 18:23:11 can the {{:subdoc}} here be on its own line? {{?e can the {{:subdoc}} here be on its own line? {{?example}} {{@.value}}{{/}} should be able to be {{?example @.value}} or even better {{?example value}} jshumway* 2013/07/24 17:40:07 same as above about own line, changed {{?example * Show quoted text On 2013/07/02 18:23:11, kalman wrote: > can the {{:subdoc}} here be on its own line? > > {{?example}} {{@.value}}{{/}} should be able to be > > {{?example @.value}} > > or even better > > {{?example value}} same as above about own line, changed {{?example value}} though.
OLD	NEW