chrome/common/extensions/docs/server2/sidenav_data_source.py - Issue 16410002: Docserver manifest follow up (rewrite)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/sidenav_data_source.py

Issue 16410002: Docserver manifest follow up (rewrite) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gen-manifest-try-2

Patch Set: Small URL change Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/server2/sidenav_data_source.py

diff --git a/chrome/common/extensions/docs/server2/sidenav_data_source.py b/chrome/common/extensions/docs/server2/sidenav_data_source.py

index 2ed1558414e2ded9219e154c0cb7e036332febf7..c4f6c6a581eccf62b0ff00fd15610fcf5a259230 100644

--- a/chrome/common/extensions/docs/server2/sidenav_data_source.py

+++ b/chrome/common/extensions/docs/server2/sidenav_data_source.py

@@ -70,7 +70,7 @@ class SidenavDataSource(object):

item['href'] = '%s%s' % (self._file_dir, href)

def get(self, key):

- sidenav_items = copy.deepcopy(self._cache.GetFromFile(

+ sidenav = copy.deepcopy(self._cache.GetFromFile(

'%s/%s_sidenav.json' % (self._json_path, key)))

self._AddSelected(sidenav)

not at google - send to devlin 2013/07/02 18:23:11 oops...? how did this happen.

jshumway 2013/07/24 17:40:07 Not sure, I think it was when I was updating the s

self._QualifyHrefs(sidenav)