chrome/common/extensions/docs/server2/sidenav_data_source.py - Issue 16410002: Docserver manifest follow up (rewrite)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/server2/sidenav_data_source.py

Issue 16410002: Docserver manifest follow up (rewrite) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gen-manifest-try-2

Patch Set: Small URL change Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/server2/manifest_data_source.py ('K') | « chrome/common/extensions/docs/server2/manifest_data_source_test.py ('k') | chrome/common/extensions/docs/templates/articles/apps_manifest.html » ('j') | chrome/common/extensions/docs/templates/json/manifest.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import copy	5 import copy

6 import json	6 import json

7	7

8 class SidenavDataSource(object):	8 class SidenavDataSource(object):

9 """This class reads in and caches a JSON file representing the side navigation	9 """This class reads in and caches a JSON file representing the side navigation

10 menu.	10 menu.

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
63 self._QualifyHrefs(item['items'])	63 self._QualifyHrefs(item['items'])

64	64

65 href = item.get('href')	65 href = item.get('href')

66 if href is not None and not href.startswith(('http://', 'https://')):	66 if href is not None and not href.startswith(('http://', 'https://')):

67 if not href.startswith('/'):	67 if not href.startswith('/'):

68 logging.warn('Paths in sidenav must be qualified. %s is not.' % href)	68 logging.warn('Paths in sidenav must be qualified. %s is not.' % href)

69 href = '/' + href	69 href = '/' + href

70 item['href'] = '%s%s' % (self._file_dir, href)	70 item['href'] = '%s%s' % (self._file_dir, href)

71	71

72 def get(self, key):	72 def get(self, key):

73 sidenav_items = copy.deepcopy(self._cache.GetFromFile(	73 sidenav = copy.deepcopy(self._cache.GetFromFile(

74 '%s/%s_sidenav.json' % (self._json_path, key)))	74 '%s/%s_sidenav.json' % (self._json_path, key)))

75 self._AddSelected(sidenav)	75 self._AddSelected(sidenav)
	not at google - send to devlin 2013/07/02 18:23:11 oops...? how did this happen. oops...? how did this happen. jshumway 2013/07/24 17:40:07 Not sure, I think it was when I was updating the s Show quoted text On 2013/07/02 18:23:11, kalman wrote: > oops...? how did this happen. Not sure, I think it was when I was updating the sidenav to use absolute URLs so it the links wouldn't break on /platform/manifest/document.html paths. I think this methods is back to the way it started.
76 self._QualifyHrefs(sidenav)	76 self._QualifyHrefs(sidenav)

77 return sidenav	77 return sidenav

OLD	NEW