Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: runtime/bin/BUILD.gn

Issue 1640773005: Make it possible to share the embedder's dart sources for the vmservice (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index b6d6ac1f26cbfdb0755af841c7c76c4396e99462..b963f09aafb55c76b2d88b852d9c5967c0f73891 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -10,9 +10,9 @@ declare_args() {
resources_sources_gypi =
exec_script("../../tools/gypi_to_gn.py",
- [rebase_path("resources_sources.gypi")],
+ [rebase_path("vmservice/vmservice_sources.gypi")],
"scope",
- ["resources_sources.gypi"])
+ ["vmservice/vmservice_sources.gypi"])
# Generate a resources.cc file for the service isolate without Observatory.
action("gen_resources_cc") {
@@ -21,7 +21,9 @@ action("gen_resources_cc") {
inputs = [
"../tools/create_resources.py",
]
- sources = resources_sources_gypi.sources
+ sources = rebase_path(resources_sources_gypi.sources,
+ "",
+ "//dart/runtime/bin/vmservice/")
zra 2016/01/28 18:40:04 Is there any way to avoid using a path here that i
Cutch 2016/01/28 23:49:44 Not that I'm aware of. Have any of these BUILD.gn
zra 2016/01/29 02:58:18 No, but it would one day be nice to switch the Dar
Cutch 2016/01/29 15:36:52 I've left a note. I would be really pleased if we
outputs = [ "$target_gen_dir/resources_gen.cc" ]
args = [
"--output",
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698