Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Side by Side Diff: runtime/bin/BUILD.gn

Issue 1640773005: Make it possible to share the embedder's dart sources for the vmservice (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 5
6 declare_args() { 6 declare_args() {
7 dart_io_support = false 7 dart_io_support = false
8 } 8 }
9 9
10 10
11 resources_sources_gypi = 11 resources_sources_gypi =
12 exec_script("../../tools/gypi_to_gn.py", 12 exec_script("../../tools/gypi_to_gn.py",
13 [rebase_path("resources_sources.gypi")], 13 [rebase_path("vmservice/vmservice_sources.gypi")],
14 "scope", 14 "scope",
15 ["resources_sources.gypi"]) 15 ["vmservice/vmservice_sources.gypi"])
16 16
17 # Generate a resources.cc file for the service isolate without Observatory. 17 # Generate a resources.cc file for the service isolate without Observatory.
18 action("gen_resources_cc") { 18 action("gen_resources_cc") {
19 visibility = [ ":*" ] # Only targets in this file can see this. 19 visibility = [ ":*" ] # Only targets in this file can see this.
20 script = "../tools/create_resources.py" 20 script = "../tools/create_resources.py"
21 inputs = [ 21 inputs = [
22 "../tools/create_resources.py", 22 "../tools/create_resources.py",
23 ] 23 ]
24 sources = resources_sources_gypi.sources 24 sources = rebase_path(resources_sources_gypi.sources,
25 "",
26 "//dart/runtime/bin/vmservice/")
zra 2016/01/28 18:40:04 Is there any way to avoid using a path here that i
Cutch 2016/01/28 23:49:44 Not that I'm aware of. Have any of these BUILD.gn
zra 2016/01/29 02:58:18 No, but it would one day be nice to switch the Dar
Cutch 2016/01/29 15:36:52 I've left a note. I would be really pleased if we
25 outputs = [ "$target_gen_dir/resources_gen.cc" ] 27 outputs = [ "$target_gen_dir/resources_gen.cc" ]
26 args = [ 28 args = [
27 "--output", 29 "--output",
28 rebase_path("$target_gen_dir/resources_gen.cc", root_build_dir), 30 rebase_path("$target_gen_dir/resources_gen.cc", root_build_dir),
29 "--outer_namespace", "dart", 31 "--outer_namespace", "dart",
30 "--inner_namespace", "bin", 32 "--inner_namespace", "bin",
31 "--table_name", "service_bin", 33 "--table_name", "service_bin",
32 "--root_prefix", rebase_path(".", root_build_dir) + "/", 34 "--root_prefix", rebase_path(".", root_build_dir) + "/",
33 ] + rebase_path(sources, root_build_dir) 35 ] + rebase_path(sources, root_build_dir)
34 } 36 }
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 "log_macos.cc", 325 "log_macos.cc",
324 "log_win.cc", 326 "log_win.cc",
325 "log.h", 327 "log.h",
326 ] 328 ]
327 329
328 include_dirs = [ 330 include_dirs = [
329 "..", 331 "..",
330 "//third_party" 332 "//third_party"
331 ] 333 ]
332 } 334 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | runtime/bin/vmservice/vmservice_io.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698