Make it possible to share the embedder's dart sources for the vmservice

Make it possible to share the embedder's dart sources for the service isolate.

- Cleanups to the embedder's Dart sources for the service isolate. This lets us stop keeping a local copy in the mojo and flutter trees.
- Let the VM know Observatory's server address.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/87d8d3a719ad08c047463d6d1260ee9c9f67874a

[Cutch, 2016-01-28 18:15:49]

Description was changed from

==========
Make it possible to share the embedder's dart sources for the vmservice

BUG=
==========

to

==========
Make it possible to share the embedder's dart sources for the service isolate.

- Cleanups to the embedder's Dart sources for the service isolate. This lets us
stop keeping a local copy in the mojo and flutter trees.
- Let the VM know Observatory's server address.
==========

[Cutch, 2016-01-28 18:15:50]

johnmccutchan@google.com changed reviewers:
+ zra@google.com

[zra, 2016-01-28 18:40:05]

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn#newcode26
runtime/bin/BUILD.gn:26: "//dart/runtime/bin/vmservice/")
Is there any way to avoid using a path here that is specific to the Mojo repo?

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
File runtime/bin/vmservice/vmservice_io.dart (left):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
runtime/bin/vmservice/vmservice_io.dart:105: // See:
https://github.com/dart-lang/sdk/issues/23977
It looks like this issue is still open. What is the status here?

https://codereview.chromium.org/1640773005/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (left):

https://codereview.chromium.org/1640773005/diff/1/runtime/vm/service.cc#oldco...
runtime/vm/service.cc:737: 
Restore newline.

[Cutch, 2016-01-28 23:49:45]

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn#newcode26
runtime/bin/BUILD.gn:26: "//dart/runtime/bin/vmservice/")
On 2016/01/28 18:40:04, zra wrote:
> Is there any way to avoid using a path here that is specific to the Mojo repo?

Not that I'm aware of. Have any of these BUILD.gn files been exercised outside
of mojo or flutter repositories?

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
File runtime/bin/vmservice/vmservice_io.dart (left):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
runtime/bin/vmservice/vmservice_io.dart:105: // See:
https://github.com/dart-lang/sdk/issues/23977
On 2016/01/28 18:40:04, zra wrote:
> It looks like this issue is still open. What is the status here?

The legacy debug protocol has been removed and the legacy coverage tool is going
away soon too. I can restore this comment but it doesn't seem useful anymore.

https://codereview.chromium.org/1640773005/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (left):

https://codereview.chromium.org/1640773005/diff/1/runtime/vm/service.cc#oldco...
runtime/vm/service.cc:737: 
On 2016/01/28 18:40:04, zra wrote:
> Restore newline.

Done.

[zra, 2016-01-29 02:58:18]

lgtm

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn#newcode26
runtime/bin/BUILD.gn:26: "//dart/runtime/bin/vmservice/")
On 2016/01/28 23:49:44, Cutch wrote:
> On 2016/01/28 18:40:04, zra wrote:
> > Is there any way to avoid using a path here that is specific to the Mojo
repo?
> 
> Not that I'm aware of. Have any of these BUILD.gn files been exercised outside
> of mojo or flutter repositories?

No, but it would one day be nice to switch the Dart build from gyp to GN. Maybe
it's a bit of a pipe dream, though. Would you mind adding a note just in case?

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
File runtime/bin/vmservice/vmservice_io.dart (left):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
runtime/bin/vmservice/vmservice_io.dart:105: // See:
https://github.com/dart-lang/sdk/issues/23977
On 2016/01/28 23:49:45, Cutch wrote:
> On 2016/01/28 18:40:04, zra wrote:
> > It looks like this issue is still open. What is the status here?
> 
> The legacy debug protocol has been removed and the legacy coverage tool is
going
> away soon too. I can restore this comment but it doesn't seem useful anymore.

So, we can either get rid of this `else` branch, or get rid of the special path
mentioned in the TODO to kill the service isolate. I'd kind of prefer getting
rid of the special path in C++ for killing the service isolate. Maybe we should
change the TODO to just say that? Up to you.

[Cutch, 2016-01-29 15:36:52]

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/BUILD.gn#newcode26
runtime/bin/BUILD.gn:26: "//dart/runtime/bin/vmservice/")
On 2016/01/29 02:58:18, zra wrote:
> On 2016/01/28 23:49:44, Cutch wrote:
> > On 2016/01/28 18:40:04, zra wrote:
> > > Is there any way to avoid using a path here that is specific to the Mojo
> repo?
> > 
> > Not that I'm aware of. Have any of these BUILD.gn files been exercised
outside
> > of mojo or flutter repositories?
> 
> No, but it would one day be nice to switch the Dart build from gyp to GN.
Maybe
> it's a bit of a pipe dream, though. Would you mind adding a note just in case?

I've left a note. I would be really pleased if we switched to GN.

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
File runtime/bin/vmservice/vmservice_io.dart (left):

https://codereview.chromium.org/1640773005/diff/1/runtime/bin/vmservice/vmser...
runtime/bin/vmservice/vmservice_io.dart:105: // See:
https://github.com/dart-lang/sdk/issues/23977
On 2016/01/29 02:58:18, zra wrote:
> On 2016/01/28 23:49:45, Cutch wrote:
> > On 2016/01/28 18:40:04, zra wrote:
> > > It looks like this issue is still open. What is the status here?
> > 
> > The legacy debug protocol has been removed and the legacy coverage tool is
> going
> > away soon too. I can restore this comment but it doesn't seem useful
anymore.
> 
> So, we can either get rid of this `else` branch, or get rid of the special
path
> mentioned in the TODO to kill the service isolate. I'd kind of prefer getting
> rid of the special path in C++ for killing the service isolate. Maybe we
should
> change the TODO to just say that? Up to you.

I've left a TODO.

[Cutch, 2016-01-29 15:43:25]

Description was changed from

==========
Make it possible to share the embedder's dart sources for the service isolate.

- Cleanups to the embedder's Dart sources for the service isolate. This lets us
stop keeping a local copy in the mojo and flutter trees.
- Let the VM know Observatory's server address.
==========

to

==========
Make it possible to share the embedder's dart sources for the service isolate.

- Cleanups to the embedder's Dart sources for the service isolate. This lets us
stop keeping a local copy in the mojo and flutter trees.
- Let the VM know Observatory's server address.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/87d8d3a719ad08c047463d6d1260ee9c9f67874a
==========

[Cutch, 2016-01-29 15:43:26]

Committed patchset #4 (id:60001) manually as
87d8d3a719ad08c047463d6d1260ee9c9f67874a (presubmit successful).