cc/surfaces/surface_factory.h - Issue 1640483003: Switch SurfaceId maps from base::hash_map to std::unordered_map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/surface_factory.h

Issue 1640483003: Switch SurfaceId maps from base::hash_map to std::unordered_map. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebasing Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/surfaces/surface_factory.h

diff --git a/cc/surfaces/surface_factory.h b/cc/surfaces/surface_factory.h

index fdfad179059d3eb1ea4e55b36d588a2f025b9994..adaab4b92e7b8727484e7168fe4bf6bfe02faffc 100644

--- a/cc/surfaces/surface_factory.h

+++ b/cc/surfaces/surface_factory.h

@@ -6,6 +6,7 @@

#define CC_SURFACES_SURFACE_FACTORY_H_

#include <set>

+#include <unordered_map>

#include "base/callback_forward.h"

#include "base/containers/scoped_ptr_hash_map.h"

@@ -85,7 +86,7 @@ class CC_SURFACES_EXPORT SurfaceFactory

bool needs_sync_points_;

- typedef base::ScopedPtrHashMap<SurfaceId, scoped_ptr<Surface>>

+ typedef std::unordered_map<SurfaceId, scoped_ptr<Surface>, SurfaceIdHash>

danakj 2016/01/26 23:53:32 can you switch this to "using" instead of "typedef

lfg 2016/01/27 00:53:14 Done.

OwningSurfaceMap;

OwningSurfaceMap surface_map_;

« cc/surfaces/surface_aggregator.cc ('K') | « cc/surfaces/surface_aggregator.cc ('k') | cc/surfaces/surface_factory.cc » ('j') | cc/surfaces/surface_factory.cc » ('J')