Chromium Code Reviews| Index: cc/surfaces/surface_factory.cc |
| diff --git a/cc/surfaces/surface_factory.cc b/cc/surfaces/surface_factory.cc |
| index 12afab82e69b063d41b23ccd6282824a8ac6ee15..529e1c62a02de1ceec1171b078eac235a83e06d2 100644 |
| --- a/cc/surfaces/surface_factory.cc |
| +++ b/cc/surfaces/surface_factory.cc |
| @@ -32,7 +32,7 @@ SurfaceFactory::~SurfaceFactory() { |
| void SurfaceFactory::DestroyAll() { |
| for (auto it = surface_map_.begin(); it != surface_map_.end(); ++it) |
|
danakj
2016/01/26 23:53:32
can you do this with a value forloop?
for (auto p
lfg
2016/01/27 00:53:14
Done.
|
| - manager_->Destroy(surface_map_.take(it)); |
| + manager_->Destroy(std::move(it->second)); |
| surface_map_.clear(); |
| } |
| @@ -40,14 +40,16 @@ void SurfaceFactory::Create(SurfaceId surface_id) { |
| scoped_ptr<Surface> surface(new Surface(surface_id, this)); |
| manager_->RegisterSurface(surface.get()); |
| DCHECK(!surface_map_.count(surface_id)); |
| - surface_map_.add(surface_id, std::move(surface)); |
| + surface_map_[surface_id] = std::move(surface); |
| } |
| void SurfaceFactory::Destroy(SurfaceId surface_id) { |
| OwningSurfaceMap::iterator it = surface_map_.find(surface_id); |
| DCHECK(it != surface_map_.end()); |
| DCHECK(it->second->factory().get() == this); |
| - manager_->Destroy(surface_map_.take_and_erase(it)); |
| + scoped_ptr<Surface> surface(std::move(it->second)); |
| + surface_map_.erase(it); |
| + manager_->Destroy(std::move(surface)); |
| } |
| void SurfaceFactory::SetBeginFrameSource(SurfaceId surface_id, |