Switch SurfaceId maps from base::hash_map to std::unordered_map.

Switch SurfaceId maps from base::hash_map to std::unordered_map.

BUG=576864
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/a57974f2b22abe5a96a8aae2dd7b47fe56bba307
Cr-Commit-Position: refs/heads/master@{#371705}

[lfg, 2016-01-26 23:33:19]

Description was changed from

==========
Switch SurfaceId maps from base::hash_map to std::unordered_map.

BUG=576864
==========

to

==========
Switch SurfaceId maps from base::hash_map to std::unordered_map.

BUG=576864
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[lfg, 2016-01-26 23:47:01]

lfg@chromium.org changed reviewers:
+ danakj@chromium.org

[lfg, 2016-01-26 23:47:02]

Hi Dana, please take a look. I've decided to split this from the other change
since there were quite a few places I had to change.

[danakj, 2016-01-26 23:53:32]

Hey, thanks for the changes. A couple little things but LGTM

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.cc:125: RenderPassIdAllocator* allocator =
You could write this code a bit shorter now I guess like

scoped_ptr<RenderPassIdAllocator>& allocator =
    render_pass_..._map_[surface_id];
if (!allocator)
  allocator.reset(new RenderPass....or(&nex.._id_);

Ie.. no need to set the thing into the map if you have a reference to it
already.

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
File cc/surfaces/surface_factory.cc (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
cc/surfaces/surface_factory.cc:34: for (auto it = surface_map_.begin(); it !=
surface_map_.end(); ++it)
can you do this with a value forloop?

for (auto pair : surface_map_)
  manager->Destroy(pair.second);

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
File cc/surfaces/surface_factory.h (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
cc/surfaces/surface_factory.h:89: typedef std::unordered_map<SurfaceId,
scoped_ptr<Surface>, SurfaceIdHash>
can you switch this to "using" instead of "typedef" while you're touching it?

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_man...
File cc/surfaces/surface_manager.h (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_man...
cc/surfaces/surface_manager.h:64: typedef std::unordered_map<SurfaceId,
Surface*, SurfaceIdHash> SurfaceMap;
can use using here too?

[davidben, 2016-01-26 23:57:01]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2016-01-26 23:57:01]

Oh hrm. I actually had https://codereview.chromium.org/1587283002/ in the
pipeline which switches the entire directory over, although it hit some Windows
build failure that I need to figure out.

[danakj, 2016-01-26 23:57:49]

On Tue, Jan 26, 2016 at 3:57 PM, <davidben@chromium.org> wrote:

> Oh hrm. I actually had https://codereview.chromium.org/1587283002/ in the
> pipeline which switches the entire directory over, although it hit some
> Windows
> build failure that I need to figure out.
>

Ya, I was hoping you can rebase on this pretty painlessly?

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[davidben, 2016-01-26 23:59:36]

On 2016/01/26 23:57:49, danakj wrote:
> On Tue, Jan 26, 2016 at 3:57 PM, <mailto:davidben@chromium.org> wrote:
> 
> > Oh hrm. I actually had https://codereview.chromium.org/1587283002/ in the
> > pipeline which switches the entire directory over, although it hit some
> > Windows
> > build failure that I need to figure out.
> >
> 
> Ya, I was hoping you can rebase on this pretty painlessly?

Sure. That seems reasonable.

[lfg, 2016-01-27 00:53:14]

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_agg...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_agg...
cc/surfaces/surface_aggregator.cc:125: RenderPassIdAllocator* allocator =
On 2016/01/26 23:53:32, danakj wrote:
> You could write this code a bit shorter now I guess like
> 
> scoped_ptr<RenderPassIdAllocator>& allocator =
>     render_pass_..._map_[surface_id];
> if (!allocator)
>   allocator.reset(new RenderPass....or(&nex.._id_);
> 
> Ie.. no need to set the thing into the map if you have a reference to it
> already.

Done.

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
File cc/surfaces/surface_factory.cc (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
cc/surfaces/surface_factory.cc:34: for (auto it = surface_map_.begin(); it !=
surface_map_.end(); ++it)
On 2016/01/26 23:53:32, danakj wrote:
> can you do this with a value forloop?
> 
> for (auto pair : surface_map_)
>   manager->Destroy(pair.second);

Done.

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
File cc/surfaces/surface_factory.h (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_fac...
cc/surfaces/surface_factory.h:89: typedef std::unordered_map<SurfaceId,
scoped_ptr<Surface>, SurfaceIdHash>
On 2016/01/26 23:53:32, danakj wrote:
> can you switch this to "using" instead of "typedef" while you're touching it?

Done.

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_man...
File cc/surfaces/surface_manager.h (right):

https://codereview.chromium.org/1640483003/diff/20001/cc/surfaces/surface_man...
cc/surfaces/surface_manager.h:64: typedef std::unordered_map<SurfaceId,
Surface*, SurfaceIdHash> SurfaceMap;
On 2016/01/26 23:53:32, danakj wrote:
> can use using here too?

Done.

[lfg, 2016-01-27 02:28:22]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-01-27 02:28:23]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1640483003/#ps40001
(title: "addressing comments")

[commit-bot: I haz the power, 2016-01-27 02:29:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1640483003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1640483003/40001

[commit-bot: I haz the power, 2016-01-27 03:35:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-27 03:37:19]

Description was changed from

==========
Switch SurfaceId maps from base::hash_map to std::unordered_map.

BUG=576864
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Switch SurfaceId maps from base::hash_map to std::unordered_map.

BUG=576864
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/a57974f2b22abe5a96a8aae2dd7b47fe56bba307
Cr-Commit-Position: refs/heads/master@{#371705}
==========

[commit-bot: I haz the power, 2016-01-27 03:37:21]

Patchset 3 (id:??) landed as
https://crrev.com/a57974f2b22abe5a96a8aae2dd7b47fe56bba307
Cr-Commit-Position: refs/heads/master@{#371705}