Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1640473002: Merge to Master: War on #defines - part 2 (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge to Master: War on #defines - part 2 Original Review URL: https://codereview.chromium.org/1634123004 . (cherry picked from commit f10ae634e7b198b18942baaf9f111f07cc8ce818) R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/badb41230bae96cba8fc481de47592836e3f43f8

Patch Set 1 #

Patch Set 2 : Pick up build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -192 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 6 chunks +25 lines, -72 lines 0 comments Download
M core/include/fpdfdoc/fpdf_ap.h View 1 3 chunks +8 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 15 chunks +62 lines, -62 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 1 8 chunks +31 lines, -20 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 4 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
TBR
4 years, 11 months ago (2016-01-26 22:23:04 UTC) #1
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-26 22:30:48 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-26 22:44:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
badb41230bae96cba8fc481de47592836e3f43f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698