War on #defines - part 2

War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/f10ae634e7b198b18942baaf9f111f07cc8ce818

[Tom Sepez, 2016-01-26 19:31:32]

Description was changed from

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Move one prototype to header, delete an unused one.
==========

to

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Move one prototype to header, delete an unused one.
Tidy whitespace.
==========

[Tom Sepez, 2016-01-26 19:31:32]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-01-26 19:36:19]

Description was changed from

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Move one prototype to header, delete an unused one.
Tidy whitespace.
==========

to

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
==========

[Tom Sepez, 2016-01-26 19:38:21]

Description was changed from

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
==========

to

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
==========

[Tom Sepez, 2016-01-26 19:41:12]

Pls. review.

[Lei Zhang, 2016-01-26 22:13:45]

lgtm

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:282: err_code = FPDF_ERR_SUCCESS;
This is NOTREACHED(), BTW.

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:414: CheckUnSupportError(pDoc, error);
BTW, all the CheckUnSupportError() errors pass |error| = SUCCESS.

[Lei Zhang, 2016-01-26 22:14:05]

On 2016/01/26 22:13:45, Lei Zhang wrote:
>
https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cp...
> fpdfsdk/src/fpdfview.cpp:414: CheckUnSupportError(pDoc, error);
> BTW, all the CheckUnSupportError() errors pass |error| = SUCCESS.

s/errors/callers/

[Tom Sepez, 2016-01-26 22:19:36]

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:282: err_code = FPDF_ERR_SUCCESS;
On 2016/01/26 22:13:44, Lei Zhang wrote:
> This is NOTREACHED(), BTW.

It exists just to satisfy the all enums handled by switch requirement.

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:414: CheckUnSupportError(pDoc, error);
On 2016/01/26 22:13:44, Lei Zhang wrote:
> BTW, all the CheckUnSupportError() errors pass |error| = SUCCESS.

Thanks.  Next time.

[Tom Sepez, 2016-01-26 22:19:55]

Description was changed from

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
==========

to

==========
War on #defines - part 2

Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/f10ae634e7b198b18942baaf9f111f07cc8c...
==========

[Tom Sepez, 2016-01-26 22:19:56]

Committed patchset #2 (id:20001) manually as
f10ae634e7b198b18942baaf9f111f07cc8ce818 (presubmit successful).

[brucedawson, 2016-02-03 19:49:07]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2016-02-03 19:49:08]

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cpp
File fpdfsdk/src/fpdfview.cpp (right):

https://codereview.chromium.org/1634123004/diff/20001/fpdfsdk/src/fpdfview.cp...
fpdfsdk/src/fpdfview.cpp:282: err_code = FPDF_ERR_SUCCESS;
On 2016/01/26 22:19:35, Tom Sepez wrote:
> On 2016/01/26 22:13:44, Lei Zhang wrote:
> > This is NOTREACHED(), BTW.
> 
> It exists just to satisfy the all enums handled by switch requirement.

Was clang giving a warning without this case? Arguably a default case would be
better because now VC++'s /analyze warns that err_code is potentially not
initialized. Ah, the joys of trying to write clean code while also keeping
multiple compilers warning clean.

Could also avoid the VC++ warning by initializing err_code to FPDF_ERR_SUCCESS.
Or just ignore.