Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1640373002: Fix broken MainThreadScrollingReason DCHECK. (Closed)

Created:
4 years, 11 months ago by tdresser
Modified:
4 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix broken MainThreadScrollingReason DCHECK. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6a65e094c8932e539c583875c7c383ad0c27303e Cr-Commit-Position: refs/heads/master@{#371843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M cc/blink/web_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/input/main_thread_scrolling_reason.h View 1 chunk +3 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640373002/1
4 years, 11 months ago (2016-01-27 18:14:15 UTC) #3
tdresser
How does this look? Should this constant live inside MainThreadScrollingReason, or outside?
4 years, 11 months ago (2016-01-27 19:01:13 UTC) #5
danakj
LGTM I was kinda thinking it would check & vs a bitmask, but since they're ...
4 years, 11 months ago (2016-01-27 19:03:54 UTC) #6
danakj
On 2016/01/27 19:01:13, tdresser wrote: > How does this look? > > Should this constant ...
4 years, 11 months ago (2016-01-27 19:04:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640373002/1
4 years, 11 months ago (2016-01-27 19:07:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 19:38:06 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 19:39:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a65e094c8932e539c583875c7c383ad0c27303e
Cr-Commit-Position: refs/heads/master@{#371843}

Powered by Google App Engine
This is Rietveld 408576698