Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Side by Side Diff: cc/input/main_thread_scrolling_reason.h

Issue 1640373002: Fix broken MainThreadScrollingReason DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_INPUT_MAIN_THREAD_SCROLLING_REASON_H_ 5 #ifndef CC_INPUT_MAIN_THREAD_SCROLLING_REASON_H_
6 #define CC_INPUT_MAIN_THREAD_SCROLLING_REASON_H_ 6 #define CC_INPUT_MAIN_THREAD_SCROLLING_REASON_H_
7 7
8 namespace cc { 8 namespace cc {
9 9
10 // Ensure this stays in sync with MainThreadScrollingReason in histograms.xml. 10 // Ensure this stays in sync with MainThreadScrollingReason in histograms.xml.
11 struct MainThreadScrollingReason { 11 struct MainThreadScrollingReason {
12 // Non-transient scrolling reasons. 12 // Non-transient scrolling reasons.
13 enum : uint32_t { kNotScrollingOnMain = 0 }; 13 enum : uint32_t { kNotScrollingOnMain = 0 };
14 enum : uint32_t { kHasBackgroundAttachmentFixedObjects = 1 << 0 }; 14 enum : uint32_t { kHasBackgroundAttachmentFixedObjects = 1 << 0 };
15 enum : uint32_t { kHasNonLayerViewportConstrainedObjects = 1 << 1 }; 15 enum : uint32_t { kHasNonLayerViewportConstrainedObjects = 1 << 1 };
16 enum : uint32_t { kThreadedScrollingDisabled = 1 << 2 }; 16 enum : uint32_t { kThreadedScrollingDisabled = 1 << 2 };
17 enum : uint32_t { kScrollbarScrolling = 1 << 3 }; 17 enum : uint32_t { kScrollbarScrolling = 1 << 3 };
18 enum : uint32_t { kPageOverlay = 1 << 4 }; 18 enum : uint32_t { kPageOverlay = 1 << 4 };
19 enum : uint32_t { kMaxNonTransientScrollingReason = kPageOverlay }; 19 // The maximum value reachable as a combination of the non-transient scrolling
20 // reasons.
21 enum : uint32_t { kMaxNonTransientScrollingReasons = (1 << 5) - 1 };
20 22
21 // Transient scrolling reasons. These are computed for each scroll begin. 23 // Transient scrolling reasons. These are computed for each scroll begin.
22 enum : uint32_t { kNonFastScrollableRegion = 1 << 5 }; 24 enum : uint32_t { kNonFastScrollableRegion = 1 << 5 };
23 enum : uint32_t { kEventHandlers = 1 << 6 }; 25 enum : uint32_t { kEventHandlers = 1 << 6 };
24 enum : uint32_t { kFailedHitTest = 1 << 7 }; 26 enum : uint32_t { kFailedHitTest = 1 << 7 };
25 enum : uint32_t { kNoScrollingLayer = 1 << 8 }; 27 enum : uint32_t { kNoScrollingLayer = 1 << 8 };
26 enum : uint32_t { kNotScrollable = 1 << 9 }; 28 enum : uint32_t { kNotScrollable = 1 << 9 };
27 enum : uint32_t { kContinuingMainThreadScroll = 1 << 10 }; 29 enum : uint32_t { kContinuingMainThreadScroll = 1 << 10 };
28 enum : uint32_t { kNonInvertibleTransform = 1 << 11 }; 30 enum : uint32_t { kNonInvertibleTransform = 1 << 11 };
29 enum : uint32_t { kPageBasedScrolling = 1 << 12 }; 31 enum : uint32_t { kPageBasedScrolling = 1 << 12 };
30 32
31 // The number of flags in this struct (excluding itself). 33 // The number of flags in this struct (excluding itself).
32 enum : uint32_t { kMainThreadScrollingReasonCount = 14 }; 34 enum : uint32_t { kMainThreadScrollingReasonCount = 14 };
33 }; 35 };
34 36
35 } // namespace cc 37 } // namespace cc
36 38
37 #endif // CC_INPUT_MAIN_THREAD_SCROLLING_REASON_H_ 39 #endif // CC_INPUT_MAIN_THREAD_SCROLLING_REASON_H_
OLDNEW
« no previous file with comments | « cc/blink/web_layer_impl.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698