Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1640293004: Support arbitrary length units for the z component of CSS property "translate" (Closed)

Created:
4 years, 11 months ago by alancutter (OOO until 2018)
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support arbitrary length units for the z component of CSS property "translate" The z component of the translate CSS property was ignoring length units and treating everything as px. This change fixes this by converting units into their px equivalent. BUG=581918 Committed: https://crrev.com/ee8d10a13194d3f7a5525e5fb9068eb3c89744fb Cr-Commit-Position: refs/heads/master@{#372011}

Patch Set 1 #

Patch Set 2 : Review change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/transforms/translate.html View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/transforms/translate-expected.html View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
alancutter (OOO until 2018)
+timloh for main change. +leviw for Length.h change.
4 years, 11 months ago (2016-01-28 00:50:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640293004/1
4 years, 11 months ago (2016-01-28 00:53:04 UTC) #5
Timothy Loh
Why don't we just call computeLength<double>?
4 years, 11 months ago (2016-01-28 00:55:58 UTC) #6
alancutter (OOO until 2018)
On 2016/01/28 at 00:55:58, timloh wrote: > Why don't we just call computeLength<double>? Done.
4 years, 11 months ago (2016-01-28 01:07:05 UTC) #8
Timothy Loh
On 2016/01/28 01:07:05, alancutter wrote: > On 2016/01/28 at 00:55:58, timloh wrote: > > Why ...
4 years, 11 months ago (2016-01-28 02:51:21 UTC) #9
alancutter (OOO until 2018)
On 2016/01/28 at 02:51:21, timloh wrote: > On 2016/01/28 01:07:05, alancutter wrote: > > On ...
4 years, 11 months ago (2016-01-28 02:53:48 UTC) #10
Timothy Loh
On 2016/01/28 02:53:48, alancutter wrote: > On 2016/01/28 at 02:51:21, timloh wrote: > > On ...
4 years, 11 months ago (2016-01-28 02:55:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1640293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1640293004/20001
4 years, 11 months ago (2016-01-28 03:07:24 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-28 04:25:39 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 04:27:05 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee8d10a13194d3f7a5525e5fb9068eb3c89744fb
Cr-Commit-Position: refs/heads/master@{#372011}

Powered by Google App Engine
This is Rietveld 408576698