Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 1640293004: Support arbitrary length units for the z component of CSS property "translate" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review change Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/transforms/translate-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index a6f2fbfc2932999d27d826b4bf618ed730c24e7d..721b3e52a7d3688ee5889ae8e085f612e1c20743 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -911,7 +911,7 @@ PassRefPtr<TranslateTransformOperation> StyleBuilderConverter::convertTranslate(
if (list.length() >= 2)
ty = convertLength(state, *list.item(1));
if (list.length() == 3)
- tz = toCSSPrimitiveValue(list.item(2))->getDoubleValue();
+ tz = toCSSPrimitiveValue(list.item(2))->computeLength<double>(state.cssToLengthConversionData());
return TranslateTransformOperation::create(tx, ty, tz, TransformOperation::Translate3D);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/transforms/translate-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698