media/base/android/media_codec_player_unittest.cc - Issue 1640123004: Propagate media session id into MediaPlayerAndroid

Unified Diff: media/base/android/media_codec_player_unittest.cc

Issue 1640123004: Propagate media session id into MediaPlayerAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pass-media-session-id-over-ipc

Patch Set: Rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/android/remote/remote_media_player_bridge.cc ('K') | « media/base/android/media_codec_player.cc ('k') | media/base/android/media_player_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_player_unittest.cc

diff --git a/media/base/android/media_codec_player_unittest.cc b/media/base/android/media_codec_player_unittest.cc

index 10ce91cf3a35678b93d12c59bf4b5259730c6d60..3c61fd92c0a217cdcac689aa7a6ae02c96dcee20 100644

--- a/media/base/android/media_codec_player_unittest.cc

+++ b/media/base/android/media_codec_player_unittest.cc

@@ -644,7 +644,7 @@ void MediaCodecPlayerTest::CreatePlayer() {

manager_.GetWeakPtr(),

base::Bind(&MockMediaPlayerManager::OnMediaResourcesRequested,

base::Unretained(&manager_)),

- scoped_ptr<MockDemuxerAndroid>(demuxer_), GURL());

+ scoped_ptr<MockDemuxerAndroid>(demuxer_), GURL(), 0);

davve 2016/02/25 09:57:32 I have the constant problem here as well (as in th

mlamouri (slow - plz ping) 2016/02/25 14:13:55 Hmm, maybe you should have version of the constant

whywhat 2016/02/29 16:26:29 What is 0? The default session? Is it used anywher

davve 2016/03/01 05:42:22 Yes, the default session. Not used much yet, but I

DCHECK(player_);

}